Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753032AbdDLFsf (ORCPT ); Wed, 12 Apr 2017 01:48:35 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:40671 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750979AbdDLFsc (ORCPT ); Wed, 12 Apr 2017 01:48:32 -0400 Date: Tue, 11 Apr 2017 22:48:28 -0700 From: Christoph Hellwig To: Richard Weinberger Cc: Oleksij Rempel , dedekind1@gmail.com, adrian.hunter@intel.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Steffen Trumtrar Subject: Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block Message-ID: <20170412054828.GA20561@infradead.org> References: <20170411095055.26328-1-o.rempel@pengutronix.de> <20170411095055.26328-4-o.rempel@pengutronix.de> <5d7d0f21-d87f-0835-c2f6-b6c9e07f73a8@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5d7d0f21-d87f-0835-c2f6-b6c9e07f73a8@nod.at> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 437 Lines: 9 On Tue, Apr 11, 2017 at 10:43:26PM +0200, Richard Weinberger wrote: > Artem, do you remember why UBIFS didn't set s_uuid in first place? It's an extremely odd field - only a hand full of file systems set it (e.g. XFS doesn't, although according to Mimi IMA supports XFS), and it's never even used outside of the IMA/EVM code. We really need a feature flag that this field is valid that IMA can check before adding more support for it.