Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753031AbdDLGIy (ORCPT ); Wed, 12 Apr 2017 02:08:54 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:57106 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752010AbdDLGIv (ORCPT ); Wed, 12 Apr 2017 02:08:51 -0400 Date: Tue, 11 Apr 2017 23:08:47 -0700 From: Christoph Hellwig To: Oleksij Rempel Cc: Richard Weinberger , Christoph Hellwig , Oleksij Rempel , dedekind1@gmail.com, adrian.hunter@intel.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH v2 2/3] fs: ubifs: update i_version on inode changes Message-ID: <20170412060847.GA23545@infradead.org> References: <20170411095055.26328-1-o.rempel@pengutronix.de> <20170411095055.26328-3-o.rempel@pengutronix.de> <20170411160530.GA25234@infradead.org> <20170412060534.meohif5djev7johp@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170412060534.meohif5djev7johp@pengutronix.de> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 454 Lines: 9 On Wed, Apr 12, 2017 at 08:05:34AM +0200, Oleksij Rempel wrote: > The code seems to confirm it. So i assumed that IMA don't care if > i_version is stored to disk or not. And i_version is the only way > to notify IMA about inode changes. > Since IMA documentation explecitley set i_version as reqieremt, so this > option was provided as well. Maybe IMA doesn't care, but if you set MS_I_VERSION the fs does give a guarantee. Sp NAK on this patch as-is.