Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753358AbdDLGvR (ORCPT ); Wed, 12 Apr 2017 02:51:17 -0400 Received: from sym2.noone.org ([178.63.92.236]:50537 "EHLO sym2.noone.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753319AbdDLGvN (ORCPT ); Wed, 12 Apr 2017 02:51:13 -0400 Date: Wed, 12 Apr 2017 08:51:04 +0200 From: Tobias Klauser To: Alan Tull Cc: Moritz Fischer , linux-fpga@vger.kernel.org, linux-kernel , matthew.gerlach@linux.intel.com Subject: Re: [PATCH] fpga: allow to compile-test Altera FPGA bridge drivers Message-ID: <20170412065104.GE31754@distanz.ch> References: <20170411092238.19624-1-tklauser@distanz.ch> <20170411143516.GD31754@distanz.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Editor: Vi IMproved 7.3 User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2719 Lines: 68 On 2017-04-11 at 17:21:19 +0200, Alan Tull wrote: > On Tue, Apr 11, 2017 at 9:35 AM, Tobias Klauser wrote: > > Hi Alan, > > > > On 2017-04-11 at 16:27:03 +0200, Alan Tull wrote: > >> On Tue, Apr 11, 2017 at 4:22 AM, Tobias Klauser wrote: > >> > >> Hi Tobias, > >> > >> Thanks for your fixes that you have been sending. I disagree with > >> this particular one (see below), but I appreciate your efforts. > > > > Thanks for your feedback on the patch. > > > >> > Add COMPILE_TEST to the Kconfig entries for the Altera SoCFPGA FPGA > >> > Bridge and the Altera FPGA Freeze Bridge drivers to allow test-compiling > >> > them on other architectures. > >> > > >> > Signed-off-by: Tobias Klauser > >> > --- > >> > drivers/fpga/Kconfig | 4 ++-- > >> > 1 file changed, 2 insertions(+), 2 deletions(-) > >> > > >> > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig > >> > index 161ba9dccede..38ab05d261bf 100644 > >> > --- a/drivers/fpga/Kconfig > >> > +++ b/drivers/fpga/Kconfig > >> > @@ -69,14 +69,14 @@ config FPGA_BRIDGE > >> > > >> > config SOCFPGA_FPGA_BRIDGE > >> > tristate "Altera SoCFPGA FPGA Bridges" > >> > - depends on ARCH_SOCFPGA && FPGA_BRIDGE > >> > + depends on (ARCH_SOCFPGA || COMPILE_TEST) && FPGA_BRIDGE > >> > >> It doesn't make sense to compile test these on other arch's. > >> The bridges enabled by this only appear on Cyclone 5 SoCFPGA parts. > > > > There are many drivers in the tree where this is the case (i.e. the > > driver is compiled on an arch where the corresponding hardware is not > > available). Still it could be benefitial IMO in order to catch compiler > > errors and warnings, e.g. due to API/header changes earlier on. I > > occasionally found this quite handy for janitorial/cleanup patches where > > I didn't have the corresponding cross-compiler/hardware. > > That sounds good and useful. > > > > > In any case, I don't feel strongly about this. So feel free to drop at > > your discretion. > > > >> > help > >> > Say Y to enable drivers for FPGA bridges for Altera SOCFPGA > >> > devices. > >> > > >> > config ALTERA_FREEZE_BRIDGE > >> > tristate "Altera FPGA Freeze Bridge" > >> > - depends on ARCH_SOCFPGA && FPGA_BRIDGE > >> > + depends on (ARCH_SOCFPGA || COMPILE_TEST) && FPGA_BRIDGE > >> > >> These bridges can be used on Altera PCIe FPGA's. So this shouldn't > >> have been dependent on ARCH_SOCFPGA in the first place. > > > > Ok. So the dependency on ARCH_SOCFPGA should be dropped altogether? I > > can send an updated patch if you want. > > Yes please. Thanks, I'll send a v2.