Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752610AbdDLGyS (ORCPT ); Wed, 12 Apr 2017 02:54:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:52088 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751079AbdDLGyQ (ORCPT ); Wed, 12 Apr 2017 02:54:16 -0400 Date: Wed, 12 Apr 2017 08:54:13 +0200 From: Johannes Thumshirn To: Bart Van Assche Cc: "jejb@linux.vnet.ibm.com" , "martin.petersen@oracle.com" , "hch@lst.de" , "linux-kernel@vger.kernel.org" , "hare@suse.de" , "linux-scsi@vger.kernel.org" Subject: Re: [PATCH RESEND] scsi: return correct blkprep status code in case scsi_init_io() fails. Message-ID: <20170412065413.GA4988@linux-x5ow.site> References: <20170411074644.6071-1-jthumshirn@suse.de> <1491936200.2654.18.camel@sandisk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1491936200.2654.18.camel@sandisk.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1381 Lines: 35 On Tue, Apr 11, 2017 at 06:43:22PM +0000, Bart Van Assche wrote: > On Tue, 2017-04-11 at 09:46 +0200, Johannes Thumshirn wrote: > > When instrumenting the SCSI layer to run into the > > !blk_rq_nr_phys_segments(rq) case the following warning emitted from the > > block layer: > > > > blk_peek_request: bad return=-22 > > > > This happens because since commit fd3fc0b4d730 ('scsi: don't BUG_ON() > > empty DMA transfers') we return the wrong error value from iscsi_prep_fn() > ^^^^^^^^^^^^^^^ > There is no?iscsi_prep_fn() in the kernel tree. Did you perhaps mean > scsi_prep_fn()? *doh* Yup, you're right. > > > back to the block layer. > > > > Signed-off-by: Johannes Thumshirn > > Fixes: fd3fc0b4d730 scsi: don't BUG_ON() empty DMA transfers > > Reviewed-by: Christoph Hellwig > > Commit fd3fc0b4d730 has a "Cc: stable" tag. I assume that that means that > this patch also needs that tag? Probably yes. I'll include both "fixes" in my resend. -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850