Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752911AbdDLHE4 (ORCPT ); Wed, 12 Apr 2017 03:04:56 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:53233 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119AbdDLHEx (ORCPT ); Wed, 12 Apr 2017 03:04:53 -0400 Date: Wed, 12 Apr 2017 09:04:22 +0200 From: Oleksij Rempel To: Christoph Hellwig Cc: Richard Weinberger , Oleksij Rempel , dedekind1@gmail.com, adrian.hunter@intel.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH v2 2/3] fs: ubifs: update i_version on inode changes Message-ID: <20170412070422.7yxnvchmhzwe6i7d@pengutronix.de> References: <20170411095055.26328-1-o.rempel@pengutronix.de> <20170411095055.26328-3-o.rempel@pengutronix.de> <20170411160530.GA25234@infradead.org> <20170412060534.meohif5djev7johp@pengutronix.de> <20170412060847.GA23545@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170412060847.GA23545@infradead.org> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:53:34 up 8 days, 23:37, 20 users, load average: 0.00, 0.00, 0.00 User-Agent: Mutt/1.6.2-neo (2016-06-11) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1219 Lines: 27 On Tue, Apr 11, 2017 at 11:08:47PM -0700, Christoph Hellwig wrote: > On Wed, Apr 12, 2017 at 08:05:34AM +0200, Oleksij Rempel wrote: > > The code seems to confirm it. So i assumed that IMA don't care if > > i_version is stored to disk or not. And i_version is the only way > > to notify IMA about inode changes. > > Since IMA documentation explecitley set i_version as reqieremt, so this > > option was provided as well. > > Maybe IMA doesn't care, but if you set MS_I_VERSION the fs does give > a guarantee. Sp NAK on this patch as-is. Ok, it was an expekted NACK :) Suddenly right now i don't have good ide to solve it. IMA just won't to know if some runtime changes was made to FS. Currently i can image fallowing variants: - rework IMA - add MS_I_TEMP_VERSION and keep i_version using for it. - add new variable for external use only. For example: ima_rt_i_version, or some thing like this. Other ideas? -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |