Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752752AbdDLHQR (ORCPT ); Wed, 12 Apr 2017 03:16:17 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:53839 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751079AbdDLHQQ (ORCPT ); Wed, 12 Apr 2017 03:16:16 -0400 Date: Wed, 12 Apr 2017 09:15:51 +0200 From: Oleksij Rempel To: Christoph Hellwig Cc: Richard Weinberger , Oleksij Rempel , dedekind1@gmail.com, adrian.hunter@intel.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Steffen Trumtrar Subject: Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block Message-ID: <20170412071551.i36yj3lzilgtntdy@pengutronix.de> References: <20170411095055.26328-1-o.rempel@pengutronix.de> <20170411095055.26328-4-o.rempel@pengutronix.de> <5d7d0f21-d87f-0835-c2f6-b6c9e07f73a8@nod.at> <20170412054828.GA20561@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170412054828.GA20561@infradead.org> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:12:14 up 8 days, 23:55, 20 users, load average: 0.00, 0.02, 0.00 User-Agent: Mutt/1.6.2-neo (2016-06-11) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1030 Lines: 24 On Tue, Apr 11, 2017 at 10:48:28PM -0700, Christoph Hellwig wrote: > On Tue, Apr 11, 2017 at 10:43:26PM +0200, Richard Weinberger wrote: > > Artem, do you remember why UBIFS didn't set s_uuid in first place? > > It's an extremely odd field - only a hand full of file systems set it > (e.g. XFS doesn't, although according to Mimi IMA supports XFS), and > it's never even used outside of the IMA/EVM code. > > We really need a feature flag that this field is valid that IMA can > check before adding more support for it. It seems to be used by mm/cleancache.c void __cleancache_init_shared_fs() but this affects only ocfs2. So, if some flag should be implemented, who should do it? :) If me, what flag should be created? -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |