Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753262AbdDLHg7 (ORCPT ); Wed, 12 Apr 2017 03:36:59 -0400 Received: from terminus.zytor.com ([65.50.211.136]:45545 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751020AbdDLHg6 (ORCPT ); Wed, 12 Apr 2017 03:36:58 -0400 Date: Wed, 12 Apr 2017 00:30:58 -0700 From: tip-bot for Joerg Roedel Message-ID: Cc: jpoimboe@redhat.com, dvlasenk@redhat.com, peterz@infradead.org, jroedel@suse.de, tglx@linutronix.de, brgerst@gmail.com, dave.hansen@linux.intel.com, linux-kernel@vger.kernel.org, hpa@zytor.com, luto@kernel.org, torvalds@linux-foundation.org, bp@alien8.de, mingo@kernel.org Reply-To: luto@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com, bp@alien8.de, mingo@kernel.org, torvalds@linux-foundation.org, peterz@infradead.org, jroedel@suse.de, jpoimboe@redhat.com, dvlasenk@redhat.com, brgerst@gmail.com, tglx@linutronix.de In-Reply-To: <1491488362-27198-1-git-send-email-joro@8bytes.org> References: <1491488362-27198-1-git-send-email-joro@8bytes.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/mm] x86/mpx: Correctly report do_mpx_bt_fault() failures to user-space Git-Commit-ID: 5ed386ec09a5d75bcf073967e55e895c2607a5c3 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1961 Lines: 57 Commit-ID: 5ed386ec09a5d75bcf073967e55e895c2607a5c3 Gitweb: http://git.kernel.org/tip/5ed386ec09a5d75bcf073967e55e895c2607a5c3 Author: Joerg Roedel AuthorDate: Thu, 6 Apr 2017 16:19:22 +0200 Committer: Ingo Molnar CommitDate: Wed, 12 Apr 2017 08:40:58 +0200 x86/mpx: Correctly report do_mpx_bt_fault() failures to user-space When this function fails it just sends a SIGSEGV signal to user-space using force_sig(). This signal is missing essential information about the cause, e.g. the trap_nr or an error code. Fix this by propagating the error to the only caller of mpx_handle_bd_fault(), do_bounds(), which sends the correct SIGSEGV signal to the process. Signed-off-by: Joerg Roedel Cc: Andy Lutomirski Cc: Borislav Petkov Cc: Brian Gerst Cc: Dave Hansen Cc: Denys Vlasenko Cc: H. Peter Anvin Cc: Josh Poimboeuf Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Fixes: fe3d197f84319 ('x86, mpx: On-demand kernel allocation of bounds tables') Link: http://lkml.kernel.org/r/1491488362-27198-1-git-send-email-joro@8bytes.org Signed-off-by: Ingo Molnar --- arch/x86/mm/mpx.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/arch/x86/mm/mpx.c b/arch/x86/mm/mpx.c index cd44ae7..1c34b76 100644 --- a/arch/x86/mm/mpx.c +++ b/arch/x86/mm/mpx.c @@ -526,15 +526,7 @@ int mpx_handle_bd_fault(void) if (!kernel_managing_mpx_tables(current->mm)) return -EINVAL; - if (do_mpx_bt_fault()) { - force_sig(SIGSEGV, current); - /* - * The force_sig() is essentially "handling" this - * exception, so we do not pass up the error - * from do_mpx_bt_fault(). - */ - } - return 0; + return do_mpx_bt_fault(); } /*