Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752929AbdDLHyC (ORCPT ); Wed, 12 Apr 2017 03:54:02 -0400 Received: from zimbra.alphalink.fr ([217.15.80.77]:60630 "EHLO zimbra.alphalink.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751079AbdDLHx7 (ORCPT ); Wed, 12 Apr 2017 03:53:59 -0400 Date: Wed, 12 Apr 2017 09:53:55 +0200 From: Guillaume Nault To: "R. Parameswaran" Cc: netdev@vger.kernel.org, kleptog@svana.org, jchapman@katalix.com, davem@redhat.com, nprachan@brocade.com, rshearma@brocade.com, stephen@networkplumber.org, sdietric@brocade.com, ciwillia@brocade.com, lboccass@brocade.com, dfawcus@brocade.com, bhong@brocade.com, jblunck@brocade.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v1 1/1] L2TP device MTU setup - tunnel socket needs a lock Message-ID: <20170412075355.mjgaerruslswcjmw@alphalink.fr> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170306 (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 770 Lines: 19 On Tue, Apr 11, 2017 at 08:14:37PM -0700, R. Parameswaran wrote: > > The MTU overhead calculation in L2TP device set-up > merged via commit b784e7ebfce8cfb16c6f95e14e8532d0768ab7ff > needs to be adjusted to lock the tunnel socket while > referencing the sub-data structures to derive the > socket's IP overhead. Thanks. Tested-by: Guillaume Nault BTW, you don't need to add "v1" for the first version of a patch. There's also no need for numbering pathes when there's only one in the series. And we normally prefix the commit message with ": ". For this patch, your subject would look like " [PATCH net-next] l2tp: ...". Also, you could have added a "Reported-by:" tag (I don't really mind in this case, but that's good practice).