Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753223AbdDLH71 (ORCPT ); Wed, 12 Apr 2017 03:59:27 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:36225 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752546AbdDLH7Z (ORCPT ); Wed, 12 Apr 2017 03:59:25 -0400 Date: Wed, 12 Apr 2017 08:59:21 +0100 From: Lee Jones To: Florian Fainelli Cc: linux-kernel@vger.kernel.org, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, Nicolas Ferre , Rob Herring , Frank Rowand , "open list:NETWORKING DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" Subject: Re: [PATCH v2 1/3] mfd: max8998: Remove CONFIG_OF around max8998_dt_match Message-ID: <20170412075921.m3yszzgayyd25iws@dell> References: <20170412044156.17351-1-f.fainelli@gmail.com> <20170412044156.17351-2-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170412044156.17351-2-f.fainelli@gmail.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1382 Lines: 42 On Tue, 11 Apr 2017, Florian Fainelli wrote: > A subsequent patch is going to make of_match_node() an inline stub when > CONFIG_OF is disabled which will properly take care of having the compiler > eliminate the variable. To avoid more #ifdef/#else, just always make the match > table available. > > Signed-off-by: Florian Fainelli > --- > drivers/mfd/max8998.c | 2 -- > 1 file changed, 2 deletions(-) If it works, great! For my own reference: Acked-for-MFD-by: Lee Jones > diff --git a/drivers/mfd/max8998.c b/drivers/mfd/max8998.c > index 4c33b8063bc3..372f681ec1bb 100644 > --- a/drivers/mfd/max8998.c > +++ b/drivers/mfd/max8998.c > @@ -129,14 +129,12 @@ int max8998_update_reg(struct i2c_client *i2c, u8 reg, u8 val, u8 mask) > } > EXPORT_SYMBOL(max8998_update_reg); > > -#ifdef CONFIG_OF > static const struct of_device_id max8998_dt_match[] = { > { .compatible = "maxim,max8998", .data = (void *)TYPE_MAX8998 }, > { .compatible = "national,lp3974", .data = (void *)TYPE_LP3974 }, > { .compatible = "ti,lp3974", .data = (void *)TYPE_LP3974 }, > {}, > }; > -#endif > > /* > * Only the common platform data elements for max8998 are parsed here from the -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog