Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753516AbdDLIml (ORCPT ); Wed, 12 Apr 2017 04:42:41 -0400 Received: from mail-pg0-f51.google.com ([74.125.83.51]:33420 "EHLO mail-pg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753427AbdDLImg (ORCPT ); Wed, 12 Apr 2017 04:42:36 -0400 Subject: Re: [PATCH v2] ACPI : Update platform device numa node based on _PXM method To: Shanker Donthineni , "Rafael J. Wysocki" References: <1490787559-15722-1-git-send-email-shankerd@codeaurora.org> Cc: Len Brown , linux-acpi , linux-kernel , Viram Sethi From: Hanjun Guo Message-ID: <0170b960-0fc4-cfc5-062e-032f6d9fead6@linaro.org> Date: Wed, 12 Apr 2017 16:42:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1490787559-15722-1-git-send-email-shankerd@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2210 Lines: 56 On 2017/3/29 19:39, Shanker Donthineni wrote: > The optional _PXM method evaluates to an integer that identifies the > proximity domain of a device object. On ACPI based kernel boot, the > field numa_node in 'struct device' is always set to -1 irrespective > of _PXM value that is specified in the ACPI device object. But in > case of device-tree based kernel boot the numa_node field is populated > and reflects to a DT property that is specified in DTS according to > the below document. > > https://www.kernel.org/doc/Documentation/devicetree/bindings/numa.txt > http://lxr.free-electrons.com/source/drivers/of/device.c#L54 > > Without this patch dev_to_node() always returns a value of -1 for all > platform devices. This patch implements support for ACPI _PXM method > and updates the platform device numa node id using acpi_get_node(), > which provides the PXM to NUMA mapping information. The individual > platform device drivers should be able to use the NUMA aware memory > allocation functions kmalloc_node() and alloc_pages_node() to improve > the performance. > > Signed-off-by: Shanker Donthineni > --- > Changes since v1: Edited commit text. > > Not all the platform devices are attached to NUMA node 0 on Qualcomm > Datacenter Technologies server chips. Platform device drivers needs > to be aware of NUMA information to improve performance. > > drivers/acpi/acpi_platform.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c > index b4c1a6a..83d953e 100644 > --- a/drivers/acpi/acpi_platform.c > +++ b/drivers/acpi/acpi_platform.c > @@ -119,11 +119,14 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev, > if (IS_ERR(pdev)) > dev_err(&adev->dev, "platform device creation failed: %ld\n", > PTR_ERR(pdev)); > - else > + else { > + set_dev_node(&pdev->dev, acpi_get_node(adev->handle)); > dev_dbg(&adev->dev, "created platform device %s\n", > dev_name(&pdev->dev)); > + } > > kfree(resources); > + > return pdev; > } > EXPORT_SYMBOL_GPL(acpi_create_platform_device); Reviewed-by: Hanjun Guo Thanks Hanjun