Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753661AbdDLIuU (ORCPT ); Wed, 12 Apr 2017 04:50:20 -0400 Received: from mail-vk0-f46.google.com ([209.85.213.46]:33546 "EHLO mail-vk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753383AbdDLIuR (ORCPT ); Wed, 12 Apr 2017 04:50:17 -0400 MIME-Version: 1.0 In-Reply-To: <20170410063907.GA20349@mail.corp.redhat.com> References: <20170406101817.14699-1-carlo@caione.org> <20170410063907.GA20349@mail.corp.redhat.com> From: Carlo Caione Date: Wed, 12 Apr 2017 10:50:16 +0200 Message-ID: Subject: Re: [PATCH v3] HID: asus: support backlight on USB keyboards To: Benjamin Tissoires Cc: Carlo Caione , jikos@kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Linux Upstreaming Team Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 737 Lines: 19 On Mon, Apr 10, 2017 at 8:39 AM, Benjamin Tissoires wrote: > On Apr 06 2017 or thereabouts, Carlo Caione wrote: >> + ret = devm_led_classdev_register(&hdev->dev, &drvdata->kbd_backlight->cdev); >> + if (ret < 0) { >> + /* No need to have this still around */ >> + devm_kfree(&hdev->dev, drvdata->kbd_backlight); >> + cancel_work_sync(&drvdata->kbd_backlight->work); > > Small nitpick, you don't need to call cancel_work_sync() here, nobody > could have called a worker. But OTOH, it doesn't hurt. > > Reviewed-by: Benjamin Tissoires Thanks Benjamin. Who should pick this up? -- Carlo Caione | +39.340.80.30.096 | Endless