Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753321AbdDLLBc (ORCPT ); Wed, 12 Apr 2017 07:01:32 -0400 Received: from smtp.domeneshop.no ([194.63.252.55]:50071 "EHLO smtp.domeneshop.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752164AbdDLLB3 (ORCPT ); Wed, 12 Apr 2017 07:01:29 -0400 Subject: Re: [PATCH v4 5/7] dt-bindings: display/panel: Add common rotation property To: Laurent Pinchart , dri-devel@lists.freedesktop.org References: <20170211184858.26421-1-noralf@tronnes.org> <20170211184858.26421-6-noralf@tronnes.org> <1802283.9kerWUhyh6@avalon> Cc: devicetree@vger.kernel.org, thomas.petazzoni@free-electrons.com, linux-kernel@vger.kernel.org From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: Date: Wed, 12 Apr 2017 13:01:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1802283.9kerWUhyh6@avalon> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2366 Lines: 59 Den 11.04.2017 07.29, skrev Laurent Pinchart: > Hi Noralf, > > On Saturday 11 Feb 2017 19:48:56 Noralf Tr?nnes wrote: >> Display panels can be oriented many ways, especially in the embedded >> world. The rotation property is a way to describe this orientation. >> The counter clockwise direction is chosen because that's what fbdev >> and drm use. >> >> Signed-off-by: Noralf Tr?nnes >> Acked-by: Thierry Reding >> --- >> >> Changes since version 3: >> - Changed display/display.txt -> display/panel/panel.txt >> >> Documentation/devicetree/bindings/display/panel/panel.txt | 4 ++++ > We now have both Documentation/devicetree/bindings/display/panel/panel.txt and > Documentation/devicetree/bindings/display/panel/panel-common.txt as they have > been merged concurrently without being aware of each other. Would you mind if > I moved this property to panel-common.txt ? Not at all, please do. > I would also like to document the property in a bit more details to avoid > confusion about the rotation direction, as "display rotation" could be > interpreted as the angle by which the display output has to be rotated to > obtain an upside-up image. What would you think of the following, am I > overdoing it, or is it even more confusing ? I was more confused at least :-) It's not important to me what the actual wording is, but I see that I have used the word 'Display' which should have been 'Panel'. Noralf. > - rotation: Panels are commonly mounted rotated, with their native orientation > not aligned with the device's orientation. The rotation property specifies the > angle in degrees between the panel's orientation and the device's orientation > (corresponding to a counter-clockwise rotation of the panel). Valid values are > 0, 90, 180 and 270. > > >> 1 file changed, 4 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/display/panel/panel.txt >> >> diff --git a/Documentation/devicetree/bindings/display/panel/panel.txt >> b/Documentation/devicetree/bindings/display/panel/panel.txt new file mode >> 100644 >> index 0000000..e2e6867 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/panel/panel.txt >> @@ -0,0 +1,4 @@ >> +Common display properties >> +------------------------- >> + >> +- rotation: Display rotation in degrees counter clockwise (0,90,180,270)