Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753410AbdDLLzo (ORCPT ); Wed, 12 Apr 2017 07:55:44 -0400 Received: from mail-oi0-f54.google.com ([209.85.218.54]:34806 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752940AbdDLLzn (ORCPT ); Wed, 12 Apr 2017 07:55:43 -0400 MIME-Version: 1.0 In-Reply-To: <1491988335-4181-1-git-send-email-sbuisson@ddn.com> References: <1491988335-4181-1-git-send-email-sbuisson@ddn.com> From: Paul Moore Date: Wed, 12 Apr 2017 07:55:41 -0400 Message-ID: Subject: Re: [PATCH] selinux: add selinux_status_get_seq() function To: Sebastien Buisson Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov, serge@hallyn.com, james.l.morris@oracle.com, eparis@parisplace.org, sds@tycho.nsa.gov, paul@paul-moore.com, Sebastien Buisson Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2198 Lines: 79 On Wed, Apr 12, 2017 at 5:12 AM, Sebastien Buisson wrote: > Add selinux_status_get_seq() function to give access to sequence > number of current SELinux policy loaded to the rest of the kernel. > > Signed-off-by: Sebastien Buisson > --- > include/linux/selinux.h | 7 +++++++ > security/selinux/ss/status.c | 21 +++++++++++++++++++++ > 2 files changed, 28 insertions(+) See my comments on your other patch, they apply here as well. > diff --git a/include/linux/selinux.h b/include/linux/selinux.h > index 44f4596..926f9f0 100644 > --- a/include/linux/selinux.h > +++ b/include/linux/selinux.h > @@ -24,12 +24,19 @@ > * selinux_is_enabled - is SELinux enabled? > */ > bool selinux_is_enabled(void); > +u32 selinux_status_get_seq(void); > #else > > static inline bool selinux_is_enabled(void) > { > return false; > } > + > +static inline u32 selinux_status_get_seq(void) > +{ > + return 0; > +} > + > #endif /* CONFIG_SECURITY_SELINUX */ > > #endif /* _LINUX_SELINUX_H */ > diff --git a/security/selinux/ss/status.c b/security/selinux/ss/status.c > index d982365..a0670d3 100644 > --- a/security/selinux/ss/status.c > +++ b/security/selinux/ss/status.c > @@ -124,3 +124,24 @@ void selinux_status_update_policyload(int seqno) > } > mutex_unlock(&selinux_status_lock); > } > + > +/* > + * selinux_status_get_seq > + * > + * It gets current sequence of policy loaded. > + */ > +u32 selinux_status_get_seq(void) > +{ > + struct selinux_kernel_status *status; > + u32 seq = 0; > + > + mutex_lock(&selinux_status_lock); > + if (selinux_status_page) { > + status = page_address(selinux_status_page); > + seq = status->sequence; > + } > + mutex_unlock(&selinux_status_lock); > + > + return seq; > +} > +EXPORT_SYMBOL_GPL(selinux_status_get_seq); > -- > 1.8.3.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-security-module" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- paul moore security @ redhat