Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753768AbdDLMRV (ORCPT ); Wed, 12 Apr 2017 08:17:21 -0400 Received: from mx2.suse.de ([195.135.220.15]:50744 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752179AbdDLMRT (ORCPT ); Wed, 12 Apr 2017 08:17:19 -0400 Date: Wed, 12 Apr 2017 14:17:17 +0200 From: Jan Kara To: Jeff Layton Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, tytso@mit.edu, jack@suse.cz, willy@infradead.org, neilb@suse.com, viro@zeniv.linux.org.uk Subject: Re: [PATCH v2 03/17] buffer: use mapping_set_error instead of setting the flag Message-ID: <20170412121717.GC1289@quack2.suse.cz> References: <20170412120614.6111-1-jlayton@redhat.com> <20170412120614.6111-4-jlayton@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170412120614.6111-4-jlayton@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 755 Lines: 32 On Wed 12-04-17 08:06:00, Jeff Layton wrote: > Signed-off-by: Jeff Layton Looks good. You can add: Reviewed-by: Jan Kara Honza > --- > fs/buffer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/buffer.c b/fs/buffer.c > index 9196f2a270da..70638941066d 100644 > --- a/fs/buffer.c > +++ b/fs/buffer.c > @@ -483,7 +483,7 @@ static void __remove_assoc_queue(struct buffer_head *bh) > list_del_init(&bh->b_assoc_buffers); > WARN_ON(!bh->b_assoc_map); > if (buffer_write_io_error(bh)) > - set_bit(AS_EIO, &bh->b_assoc_map->flags); > + mapping_set_error(bh->b_assoc_map, -EIO); > bh->b_assoc_map = NULL; > } > > -- > 2.9.3 > -- Jan Kara SUSE Labs, CR