Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754427AbdDLM3c (ORCPT ); Wed, 12 Apr 2017 08:29:32 -0400 Received: from mx2.suse.de ([195.135.220.15]:52657 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754403AbdDLM33 (ORCPT ); Wed, 12 Apr 2017 08:29:29 -0400 Date: Wed, 12 Apr 2017 14:29:21 +0200 From: Jan Kara To: Jeff Layton Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, tytso@mit.edu, jack@suse.cz, willy@infradead.org, neilb@suse.com, viro@zeniv.linux.org.uk Subject: Re: [PATCH v2 04/17] ext2: don't test/clear AS_EIO flag Message-ID: <20170412122921.GD1289@quack2.suse.cz> References: <20170412120614.6111-1-jlayton@redhat.com> <20170412120614.6111-5-jlayton@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170412120614.6111-5-jlayton@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1413 Lines: 42 On Wed 12-04-17 08:06:01, Jeff Layton wrote: > ext2 does a test+clear of AS_EIO flag. With the new error reporting > infrastructure, we don't need to clear anything. Sample the file's > current error code, and after writeback just report whether any > errors have been seen since then. > > Signed-off-by: Jeff Layton > --- > fs/ext2/file.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/fs/ext2/file.c b/fs/ext2/file.c > index b21891a6bfca..0ca77d337c94 100644 > --- a/fs/ext2/file.c > +++ b/fs/ext2/file.c > @@ -177,7 +177,12 @@ int ext2_fsync(struct file *file, loff_t start, loff_t end, int datasync) > struct address_space *mapping = sb->s_bdev->bd_inode->i_mapping; > > ret = generic_file_fsync(file, start, end, datasync); > - if (ret == -EIO || test_and_clear_bit(AS_EIO, &mapping->flags)) { > + if (ret == -EIO) > + ret = -EIO; > + else > + ret = filemap_check_errors(mapping); > + IMO making __generic_file_fsync() perform the filemap_check_errors() after sync_mapping_buffers() is better and deals with all filesystem using generic_file_fsync(). Then we can just remove the AS_EIO check here. Honza > + if (ret) { > /* We don't really know where the IO error happened... */ > ext2_error(sb, __func__, > "detected IO error when writing metadata buffers"); > -- > 2.9.3 > -- Jan Kara SUSE Labs, CR