Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753419AbdDLOYI (ORCPT ); Wed, 12 Apr 2017 10:24:08 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:50608 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752209AbdDLOYE (ORCPT ); Wed, 12 Apr 2017 10:24:04 -0400 From: Vivien Didelot To: Florian Fainelli , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn Subject: Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY In-Reply-To: References: <20170411205237.29309-1-vivien.didelot@savoirfairelinux.com> Date: Wed, 12 Apr 2017 10:22:34 -0400 Message-ID: <871ssx1z9x.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 950 Lines: 30 Hi Florian, Florian Fainelli writes: > On 04/11/2017 01:52 PM, Vivien Didelot wrote: >> This patch moves as is the legacy DSA code from dsa.c to legacy.c, >> except the few shared symbols which remain in dsa.c. >> >> Compile legacy.o only if a new CONFIG_NET_DSA_LEGACY symbol is enabled, >> which is true by default. >> >> DSA drivers without legacy support don't need the probe function as well >> as driver registration helpers anymore, so remove their definitions if >> CONFIG_NET_DSA_LEGACY is disabled. >> >> NET_DSA_MV88E6060 and NET_DSA_BCM_SF2 now depend on the legacy support. > > BCM_SF2 is not dependent on legacy support since it got converted to the > new API in the past few months. Oops, my bad. Fixing it. > You may want to generate your patch with git format-patch -M to help > detect renames/code movements. I used --find-copies-harder -C for easier review but I can use -M. Thanks, Vivien