Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754122AbdDLO2R (ORCPT ); Wed, 12 Apr 2017 10:28:17 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:58903 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752599AbdDLO2P (ORCPT ); Wed, 12 Apr 2017 10:28:15 -0400 Date: Wed, 12 Apr 2017 07:28:14 -0700 From: Matthew Wilcox To: Jeff Layton Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, tytso@mit.edu, jack@suse.cz, neilb@suse.com, viro@zeniv.linux.org.uk Subject: Re: [PATCH v2 02/17] mm: fix mapping_set_error call in me_pagecache_dirty Message-ID: <20170412142814.GB784@bombadil.infradead.org> References: <20170412120614.6111-1-jlayton@redhat.com> <20170412120614.6111-3-jlayton@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170412120614.6111-3-jlayton@redhat.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 432 Lines: 9 On Wed, Apr 12, 2017 at 08:05:59AM -0400, Jeff Layton wrote: > The error code should be negative. Since this ends up in the default > case anyway, this is harmless, but it's less confusing to negate it. > Also, later patches will require a negative error code here. > > Signed-off-by: Jeff Layton > Reviewed-by: Ross Zwisler Reviewed-by: Matthew Wilcox