Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754569AbdDLPoT (ORCPT ); Wed, 12 Apr 2017 11:44:19 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:36470 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754468AbdDLPoP (ORCPT ); Wed, 12 Apr 2017 11:44:15 -0400 Date: Thu, 13 Apr 2017 15:41:03 +0800 From: Dong Aisheng To: Mark Brown Cc: Dong Aisheng , linux-kernel@vger.kernel.org, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, lgirdwood@gmail.com, yibin.gong@nxp.com, Richard Zhu Subject: Re: [PATCH 6/6] regulator: anatop: set default voltage selector for pcie Message-ID: <20170413074103.GC23163@b29396-OptiPlex-7040> References: <1491962327-12477-1-git-send-email-aisheng.dong@nxp.com> <1491962327-12477-6-git-send-email-aisheng.dong@nxp.com> <20170411204003.avoe5a6o52kx5on2@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170411204003.avoe5a6o52kx5on2@sirena.org.uk> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 648 Lines: 22 On Tue, Apr 11, 2017 at 09:40:03PM +0100, Mark Brown wrote: > On Wed, Apr 12, 2017 at 09:58:47AM +0800, Dong Aisheng wrote: > > Set the initial voltage selector for vddpcie in case it's disabled > > by default. > > Why is this the only anatop regulator which can have this problem and > how do we know this is a good value? Anatop regulator has no separate gate bit. e.g. 00000 Power gated off 00001 Target core voltage = 0.725V ... So it may have no valid default voltage in case it's disabled in bootloader. e.g. regulator_enable() may not work. The default voltage 1.100v this patch sets is defined in reference manual. Regards Dong Aisheng