Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754630AbdDLQAp (ORCPT ); Wed, 12 Apr 2017 12:00:45 -0400 Received: from mail-qk0-f171.google.com ([209.85.220.171]:33363 "EHLO mail-qk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754524AbdDLQAn (ORCPT ); Wed, 12 Apr 2017 12:00:43 -0400 MIME-Version: 1.0 In-Reply-To: <20170412155336.vhhrftqmlxhti36n@sirena.org.uk> References: <1491962327-12477-1-git-send-email-aisheng.dong@nxp.com> <1491962327-12477-2-git-send-email-aisheng.dong@nxp.com> <20170411203124.y7cwyttqfu4a2aov@sirena.org.uk> <20170413071101.GA23163@b29396-OptiPlex-7040> <20170412155336.vhhrftqmlxhti36n@sirena.org.uk> From: Dong Aisheng Date: Thu, 13 Apr 2017 00:00:36 +0800 Message-ID: Subject: Re: [PATCH 2/6] regulator: anatop: only set supply regulator when it actually exists To: Mark Brown Cc: Dong Aisheng , "linux-kernel@vger.kernel.org" , Shawn Guo , "linux-arm-kernel@lists.infradead.org" , "kernel@pengutronix.de" , Liam Girdwood , yibin.gong@nxp.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 668 Lines: 20 On Wed, Apr 12, 2017 at 11:53 PM, Mark Brown wrote: > On Thu, Apr 13, 2017 at 03:11:01PM +0800, Dong Aisheng wrote: > >> You're absolutely right! >> I did this because there're some where else did the same thing. >> e.g. drivers/regulator/fixed.c. > >> But it's obviously none of any platform specific and is perfectly >> to be handled in regulator core. > > Did my patch solve the problems you were seeing? I just wrote it > quickly last thing before I finished for the evening. It can solve the problem. But it breaks some thing and need a further tiny fix. I just replied the mail in your patch thread. Please check it! Regards Dong Aisheng