Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754662AbdDLQQn (ORCPT ); Wed, 12 Apr 2017 12:16:43 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:36210 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752497AbdDLQQk (ORCPT ); Wed, 12 Apr 2017 12:16:40 -0400 Date: Wed, 12 Apr 2017 17:16:32 +0100 From: Mark Brown To: Lucas Stach Cc: Dong Aisheng , Dong Aisheng , Richard Zhu , lgirdwood@gmail.com, linux-kernel@vger.kernel.org, kernel@pengutronix.de, yibin.gong@nxp.com, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Message-ID: <20170412161631.d45jtyqgcky2cqxm@sirena.org.uk> References: <1491962327-12477-1-git-send-email-aisheng.dong@nxp.com> <1491962327-12477-6-git-send-email-aisheng.dong@nxp.com> <20170411204003.avoe5a6o52kx5on2@sirena.org.uk> <20170413074103.GC23163@b29396-OptiPlex-7040> <1492013514.15082.35.camel@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pfywbwq264tqtosd" Content-Disposition: inline In-Reply-To: <1492013514.15082.35.camel@pengutronix.de> X-Cookie: We just joined the civil hair patrol! User-Agent: NeoMutt/20170306 (1.8.0) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 6/6] regulator: anatop: set default voltage selector for pcie X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1184 Lines: 34 --pfywbwq264tqtosd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 12, 2017 at 06:11:54PM +0200, Lucas Stach wrote: > Am Donnerstag, den 13.04.2017, 15:41 +0800 schrieb Dong Aisheng: > > The default voltage 1.100v this patch sets is defined in reference > > manual. > Huh? Shouldn't regulator_enable bring the voltage in a range defined by > the constraints in the DT? As part of that process it checks what the current voltage is but with this regulator you can't read the voltage if the regulator is powered off and we don't just ignore that error. --pfywbwq264tqtosd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAljuUt8ACgkQJNaLcl1U h9D02wf/VHiTmFzAy20B8FwjlCajkoXxFcFSiCL8KRTXFkiARntIzYd5UvJy4qs3 m15V/yRppigVEUoZoGnU3Z3LWP1npjHig1cpicprENchD727KTD6j/+7NqCBaN9y PV9dbC36o5P6YlOz61QDxpzBAj+dux2OPxd2kiN1aC/BKTjmuRyUQZKgF2zUY3HK NbMnp/Ja9SE64TX8PjVrLsO+AtB7ZkTUzJTsg5z3vJXRwteJpuvHo4FrNFkhHhPk nD9Yv0tHqtDMNDc2yHoUp74Cs+17EL6s3dJiOwKfiORfVAx3c1g9xgq3liOkHuWc dakiwrdquYiGLKg+w2jmiZOU+ZQ6Ug== =iIhg -----END PGP SIGNATURE----- --pfywbwq264tqtosd--