Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755128AbdDLQag (ORCPT ); Wed, 12 Apr 2017 12:30:36 -0400 Received: from mga14.intel.com ([192.55.52.115]:25333 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754906AbdDLQac (ORCPT ); Wed, 12 Apr 2017 12:30:32 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,191,1488873600"; d="scan'208";a="955290389" Date: Wed, 12 Apr 2017 09:30:31 -0700 From: Andi Kleen To: Michal Hocko , Matthew Wilcox , akpm@linux-foundation.org, mtk.manpages@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Davidlohr Bueso , khandual@linux.vnet.ibm.com Subject: Re: [PATCH] mm,hugetlb: compute page_size_log properly Message-ID: <20170412163031.GE4021@tassilo.jf.intel.com> References: <1488992761-9464-1-git-send-email-dave@stgolabs.net> <20170328165343.GB27446@linux-80c1.suse> <20170328165513.GC27446@linux-80c1.suse> <20170328175408.GD7838@bombadil.infradead.org> <20170329080625.GC27994@dhcp22.suse.cz> <20170329174514.GB4543@tassilo.jf.intel.com> <20170330061245.GA1972@dhcp22.suse.cz> <20170412161829.GA16422@linux-80c1.suse> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170412161829.GA16422@linux-80c1.suse> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 929 Lines: 25 On Wed, Apr 12, 2017 at 09:18:29AM -0700, Davidlohr Bueso wrote: > On Thu, 30 Mar 2017, Michal Hocko wrote: > > > On Wed 29-03-17 10:45:14, Andi Kleen wrote: > > > On Wed, Mar 29, 2017 at 10:06:25AM +0200, Michal Hocko wrote: > > > > > > > > Do we actually have any users? > > > > > > Yes this feature is widely used. > > > > Considering that none of SHM_HUGE* has been exported to the userspace > > headers all the users would have to use the this flag by the value and I > > am quite skeptical that application actually do that. Could you point me > > to some projects that use this? > > Hmm Andrew, if there's not one example, could you please pick up this patch? ?!? We just don't break user ABIs this way in Linux! Just because you don't like something you cannot simply remove it. I don't know if there are open source users, but there are known closed source users for which this was originally implemented. -Andi