Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754754AbdDLRd4 (ORCPT ); Wed, 12 Apr 2017 13:33:56 -0400 Received: from anholt.net ([50.246.234.109]:57002 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752205AbdDLRdy (ORCPT ); Wed, 12 Apr 2017 13:33:54 -0400 From: Eric Anholt To: Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Gustavo Padovan Subject: Re: [PATCH 3/3] drm/vc4: Add support for dma-buf fencing. In-Reply-To: <20170412124818.gupwxi732srzeqh7@phenom.ffwll.local> References: <20170411014414.20280-1-eric@anholt.net> <20170411014414.20280-3-eric@anholt.net> <20170412124818.gupwxi732srzeqh7@phenom.ffwll.local> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Wed, 12 Apr 2017 10:33:51 -0700 Message-ID: <87wpap7cow.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1917 Lines: 45 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Daniel Vetter writes: > On Mon, Apr 10, 2017 at 06:44:14PM -0700, Eric Anholt wrote: >> This is needed for proper synchronization with display on another DRM >> device (pl111 or tinydrm) with buffers produced by vc4 V3D. Fixes the >> new igt vc4_dmabuf_poll testcase, and rendering of one of the glmark2 >> desktop tests on pl111+vc4. >>=20 >> This doesn't yet introduce waits on other device's fences before vc4's >> rendering/display, because I don't have testcases for them. >>=20 >> Signed-off-by: Eric Anholt >> Cc: Gustavo Padovan > > So not sure I didn't look hard enough or why exactly, but I didn't find > anything like ->prepare_fb as implemented in e.g. drm_fb_cma_prepare_fb(). > Where is that? Otherwise looks good to me. Yeah, I need to sort that out for vc4 as a consumer of busy buffers still. This patch just does vc4 as the producer. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAljuZP8ACgkQtdYpNtH8 nuj/RQ//aostSRjK8b2R0dd+l2g86wZPcZJmR7Zm7aKg9jEMV/Qg6exqEUiqDi7U 9qTHF5odyWE3+wGiRUkY6jDNKPO+4nrblKPLlLow+goUvuX0Q0CjuTKE4Bx0Oml2 HHe1lZk1RERUZOmhIJcdsNzXVYUPFuaRzR1aAGRaLM7Yn3W7AKJ5sCU8gfh3CeZD I3CsqAY4MR9+v3McMfMsC/KV8ZKfSDhmPP9GGLdYomEy4qBHTUh2BHT2u0sDMMHq N7pQnhHmxnXPEVQJB68VCG68Je2cwD4+JUM4tfgyKrIDUy/6X9aQXbWaaosd5Aer B9/nwRbzcjfvuAg76aR3WakKlgsfrYl+1HYK7z5VIosO9qyjIB3RGNz901NqajVf CkVI4DGfyvmjg58TXNNMsaLXaekntB448RC5qn6v+61qK83CbV1Tfg4EDKXMLqWa 9paadEfDkaSibiA8cbldTpFbhyX3zwk3bqvxKiQ/bJKmmJpnxfAzugS9cx3vPLFM RQy2fg3VZFfMmB63CTZKUQHMzAYCJ/zGLwsmLATgojf4LFaA3vH9Q+ksCQ0S32Y7 Ynr1D0xDcvad1L9wOh1M5JkJL2TmzguXFypQpawjpjh1qbAbkFrPSDpRtN8aYAsM DGGJo1CHw7Y25CDCKuMjpUW84IVBgP6UhSHTtflD4C0uf3J52bA= =JXlr -----END PGP SIGNATURE----- --=-=-=--