Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264667AbTFAQje (ORCPT ); Sun, 1 Jun 2003 12:39:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264668AbTFAQje (ORCPT ); Sun, 1 Jun 2003 12:39:34 -0400 Received: from smtp.bitmover.com ([192.132.92.12]:63431 "EHLO smtp.bitmover.com") by vger.kernel.org with ESMTP id S264667AbTFAQjd (ORCPT ); Sun, 1 Jun 2003 12:39:33 -0400 Date: Sun, 1 Jun 2003 09:52:52 -0700 From: Larry McVoy To: Steven Cole Cc: Larry McVoy , Jonathan Lundell , linux-kernel@vger.kernel.org Subject: Re: Question about style when converting from K&R to ANSI C. Message-ID: <20030601165252.GD3012@work.bitmover.com> Mail-Followup-To: Larry McVoy , Steven Cole , Larry McVoy , Jonathan Lundell , linux-kernel@vger.kernel.org References: <1054446976.19557.23.camel@spc> <20030601132626.GA3012@work.bitmover.com> <20030601134942.GA10750@alpha.home.local> <20030601140602.GA3641@work.bitmover.com> <20030601161133.GC3012@work.bitmover.com> <1054485978.19557.93.camel@spc> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1054485978.19557.93.camel@spc> User-Agent: Mutt/1.4i X-MailScanner-Information: Please contact the ISP for more information X-MailScanner: Found to be clean X-MailScanner-SpamCheck: not spam (whitelisted), SpamAssassin (score=0.5, required 7, AWL, DATE_IN_PAST_06_12) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 917 Lines: 41 > Thanks for the input. You've convinced me. When going through > arch/ppc/xmon/xmon.c, I will leave things like the following unchanged: > > /* Command interpreting routine */ > static int > cmds(struct pt_regs *excp) > { Great. > My changes will be similar to the following: > > @@ -1837,9 +1818,7 @@ > return *lineptr++; > } > > -void > -take_input(str) > -char *str; > +void take_input(char *str) > { > lineptr = str; > } OK, I'm confused. You said you were convinced but then shouldn't that be void take_input(char *str) { lineptr = str; } ?? -- --- Larry McVoy lm at bitmover.com http://www.bitmover.com/lm - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/