Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754634AbdDLUAh (ORCPT ); Wed, 12 Apr 2017 16:00:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59312 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755308AbdDLUAf (ORCPT ); Wed, 12 Apr 2017 16:00:35 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C0336EB2D7 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=david@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C0336EB2D7 Subject: Re: [PATCH 2/6] KVM: VMX: remove bogus check for invalid EPT violation To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <1490867732-16743-1-git-send-email-pbonzini@redhat.com> <1490867732-16743-3-git-send-email-pbonzini@redhat.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <60bc8a46-1034-c611-4525-18496fc57bf1@redhat.com> Date: Wed, 12 Apr 2017 22:00:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1490867732-16743-3-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 12 Apr 2017 20:00:34 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 649 Lines: 19 On 30.03.2017 11:55, Paolo Bonzini wrote: > handle_ept_violation is checking for "guest-linear-address invalid" + > "not a paging-structure walk". However, _all_ EPT violations without > a valid guest linear address are paging structure walks, because those > EPT violations happen when loading the guest PDPTEs. > > Therefore, the check can never be true, and even if it were, KVM doesn't > care about the guest linear address; it only uses the guest *physical* > address VMCS field. So, remove the check altogether. > > Signed-off-by: Paolo Bonzini Reviewed-by: David Hildenbrand -- Thanks, David