Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755414AbdDLUMm (ORCPT ); Wed, 12 Apr 2017 16:12:42 -0400 Received: from mx2.suse.de ([195.135.220.15]:60489 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753231AbdDLUMi (ORCPT ); Wed, 12 Apr 2017 16:12:38 -0400 Date: Wed, 12 Apr 2017 22:12:35 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Carlo Caione cc: Benjamin Tissoires , Carlo Caione , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Linux Upstreaming Team Subject: Re: [PATCH v3] HID: asus: support backlight on USB keyboards In-Reply-To: Message-ID: References: <20170406101817.14699-1-carlo@caione.org> <20170410063907.GA20349@mail.corp.redhat.com> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 708 Lines: 22 On Wed, 12 Apr 2017, Carlo Caione wrote: > >> + ret = devm_led_classdev_register(&hdev->dev, &drvdata->kbd_backlight->cdev); > >> + if (ret < 0) { > >> + /* No need to have this still around */ > >> + devm_kfree(&hdev->dev, drvdata->kbd_backlight); > >> + cancel_work_sync(&drvdata->kbd_backlight->work); > > > > Small nitpick, you don't need to call cancel_work_sync() here, nobody > > could have called a worker. But OTOH, it doesn't hurt. > > > > Reviewed-by: Benjamin Tissoires > > Thanks Benjamin. Who should pick this up? I am going to. I'll drop the cancel_work_sync() call while doing it, ok? -- Jiri Kosina SUSE Labs