Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755430AbdDLUN6 (ORCPT ); Wed, 12 Apr 2017 16:13:58 -0400 Received: from mail-vk0-f50.google.com ([209.85.213.50]:33442 "EHLO mail-vk0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755145AbdDLUN5 (ORCPT ); Wed, 12 Apr 2017 16:13:57 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170406101817.14699-1-carlo@caione.org> <20170410063907.GA20349@mail.corp.redhat.com> From: Carlo Caione Date: Wed, 12 Apr 2017 22:13:55 +0200 Message-ID: Subject: Re: [PATCH v3] HID: asus: support backlight on USB keyboards To: Jiri Kosina Cc: Benjamin Tissoires , Carlo Caione , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Linux Upstreaming Team Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 855 Lines: 26 On Wed, Apr 12, 2017 at 10:12 PM, Jiri Kosina wrote: > On Wed, 12 Apr 2017, Carlo Caione wrote: > >> >> + ret = devm_led_classdev_register(&hdev->dev, &drvdata->kbd_backlight->cdev); >> >> + if (ret < 0) { >> >> + /* No need to have this still around */ >> >> + devm_kfree(&hdev->dev, drvdata->kbd_backlight); >> >> + cancel_work_sync(&drvdata->kbd_backlight->work); >> > >> > Small nitpick, you don't need to call cancel_work_sync() here, nobody >> > could have called a worker. But OTOH, it doesn't hurt. >> > >> > Reviewed-by: Benjamin Tissoires >> >> Thanks Benjamin. Who should pick this up? > > I am going to. > > I'll drop the cancel_work_sync() call while doing it, ok? Sure, go for it. Thank you, -- Carlo Caione | +39.340.80.30.096 | Endless