Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932177AbdDLUWz (ORCPT ); Wed, 12 Apr 2017 16:22:55 -0400 Received: from mx2.suse.de ([195.135.220.15]:32959 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755442AbdDLUWx (ORCPT ); Wed, 12 Apr 2017 16:22:53 -0400 Date: Wed, 12 Apr 2017 22:22:38 +0200 From: Borislav Petkov To: Vishal Verma Cc: linux-kernel@vger.kernel.org, linux-nvdimm@ml01.01.org, x86@kernel.org, Ross Zwisler , Tony Luck , Dan Williams Subject: Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from 'atomic' Message-ID: <20170412202238.5d327vmwjqvbzzop@pd.tnic> References: <20170411224457.24777-1-vishal.l.verma@intel.com> <20170412091442.dwonfr4dwyta7nvx@pd.tnic> <20170412195903.GA29506@omniknight.lm.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170412195903.GA29506@omniknight.lm.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 762 Lines: 28 On Wed, Apr 12, 2017 at 01:59:03PM -0600, Vishal Verma wrote: > I don't think we can do anything about the panic path errors. Then the fix should be a lot easier: --- diff --git a/drivers/acpi/nfit/mce.c b/drivers/acpi/nfit/mce.c index 3ba1c3472cf9..44c092ec2ac9 100644 --- a/drivers/acpi/nfit/mce.c +++ b/drivers/acpi/nfit/mce.c @@ -25,6 +25,9 @@ static int nfit_handle_mce(struct notifier_block *nb, unsigned long val, struct acpi_nfit_desc *acpi_desc; struct nfit_spa *nfit_spa; + if (in_atomic()) + return NOTIFY_DONE; + /* We only care about memory errors */ if (!(mce->status & MCACOD)) return NOTIFY_DONE; -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --