Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755512AbdDLUwc (ORCPT ); Wed, 12 Apr 2017 16:52:32 -0400 Received: from mga04.intel.com ([192.55.52.120]:51535 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751131AbdDLUwa (ORCPT ); Wed, 12 Apr 2017 16:52:30 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,191,1488873600"; d="scan'208";a="1134625582" Date: Wed, 12 Apr 2017 13:52:30 -0700 From: "Luck, Tony" To: "Verma, Vishal L" Cc: "bp@suse.de" , "Williams, Dan J" , "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" , "ross.zwisler@linux.intel.com" , "x86@kernel.org" Subject: Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from 'atomic' Message-ID: <20170412205229.GA13659@intel.com> References: <20170411224457.24777-1-vishal.l.verma@intel.com> <20170412091442.dwonfr4dwyta7nvx@pd.tnic> <20170412195903.GA29506@omniknight.lm.intel.com> <20170412202238.5d327vmwjqvbzzop@pd.tnic> <1492028744.2738.14.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1492028744.2738.14.camel@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 365 Lines: 14 On Wed, Apr 12, 2017 at 01:27:05PM -0700, Verma, Vishal L wrote: > > ? /* We only care about memory errors */ > > ? if (!(mce->status & MCACOD)) > > ? return NOTIFY_DONE; N.B. that isn't a valid test that this is a memory error. You need if (!(m->status & 0xef80) == BIT(7)) return NOTIFY_DONE; See: Intel SDM Volume 3B - 15.9.2 Compound Error Codes -Tony