Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755644AbdDLXVo (ORCPT ); Wed, 12 Apr 2017 19:21:44 -0400 Received: from mail-by2nam03on0065.outbound.protection.outlook.com ([104.47.42.65]:48480 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752372AbdDLXVk (ORCPT ); Wed, 12 Apr 2017 19:21:40 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=cavium.com; Subject: Re: [PATCH v13 0/6] Cavium MMC driver To: Aaro Koskinen , Jan Glauber References: <20170330153128.22842-1-jglauber@cavium.com> <20170412223750.mcm62ns57uag6y7q@raspberrypi-3.musicnaut.iki.fi> Cc: Ulf Hansson , David Daney , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org From: "Steven J. Hill" Message-ID: <44e49a3b-ec51-7318-f6c1-911712127ddb@cavium.com> Date: Wed, 12 Apr 2017 18:21:32 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170412223750.mcm62ns57uag6y7q@raspberrypi-3.musicnaut.iki.fi> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Originating-IP: [50.82.184.123] X-ClientProxiedBy: CY4PR02CA0036.namprd02.prod.outlook.com (10.175.57.150) To MWHPR07MB3215.namprd07.prod.outlook.com (10.172.96.149) X-MS-Office365-Filtering-Correlation-Id: 0759c676-8389-49ec-8458-08d481faaa79 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:MWHPR07MB3215; X-Microsoft-Exchange-Diagnostics: 1;MWHPR07MB3215;3:MvjgrhmTMz2ePv7iCK3K9cd5S1LhxkfzJPFPAvee+wxLZnb90PCYs0RRYqPPDPz/Rb4MR5ucclStSP4Rmyrh1etXnd1U7aeMgDMTrHVPvoLt/xYBbQpUBjcX78R5JaI6EeHffGLrmyGch+aWM+ETxnQm85asl5ixzGwTlAx0+pL81pgKAcLTP5q2+NFx1H7s+GQRBbfMj2aiXxdvPGAzSSwXrUoPwxnXh3FG5iF3jCzePouNha8z2wT7OD+3r468/oCOUQNaGjJJdif5K7l88WXjY77FQDuNqwb6WBSKivS6yEOup0iibGXqAnazU7OEXSQqN2u1exUf5704xpCJIA==;25:t3FS7kpNSkFYzR8LfrLgHregH7wP92Vkh7+Ees6ZVeVri700G0Gh6hH6dr1D/z25CBdWo6TJh/lD+q7dhr5D40v8GMjsy9rVwiH3WUel26fLj5jNoR6qK6OQBVmKo6lgRgNZchRh3SDubDsS10tTJ/rHpXIOLvdupNKzqNPtD3hc7s9pUQWNsEI+LG/PI1W8PMyXGTCbBm0ThH3yA8/n8jGnMxmzAluiuprm4oysxvhSbq1k1erPZjhPC5nnqie5dXDV/AYbL2hs+TLxBN15RmnQ/GtE9RJ0QD2j0ZMIDMV2809ipspviMa0416YrIf9E2JBiyHQKkObDhckN0c+46L3YctIzL84gYmiKYMuqdDJynRyqlm2JW4Q6lWI5BXQhbEM46YD2tdCb8M3EVR7QWXSXGgzOalKqwvvnXvEitNmKYkysnNbW/XJbFZkm2gUuoe/s7FTAirJsTHSRyCxDA== X-Microsoft-Exchange-Diagnostics: 1;MWHPR07MB3215;31:i3T8t6MRxNA1hLKooFtTId29wP4hjoBnN6MwUr7EI40NfbiiH4Js0DMd3ihixoAjtH7CRY1GdYUWtmrMPd4JIFksCg1o5WEOwD6sdzT7lzz4k454Vzs7aeNat2DB9nXdtbnJGFD5vo5chj0L6nJHLDnftXI0Qb3Q2BK1JQo6tI/5gtiABDP27O+7xGIj12HstxNEpGrNdtQA4h0+LXHe8gAWOK57Ce/ymq5aFjl+NpIv7ouYbp31mkWX1XfSK7xOW4/RBB5MN0RKmpZGdVU6Pw==;20:wq3F5mbXZ8hNc6PZtyP9B6nXccYgU+XMSQd9rh3Luk+sBAFBuTcR/ecimizqq0fh5nOgH9rSLhiY0FsUJl08bettzIDXmPDr5BRjhuvbCXkt1TvwksHYLF3O7uQYfiXhkdNTk5uJyT3Zmy4RCyBpFopb7tph+kOuOJqafLCCvELiQV/85itGY9DJC/5eZk0ykWY8VagjAjcRXGuAOGHrnKEkbgkBnkf+1gVyWjNkGtNStxqt9gjptN8i5dDNYiix6sqzcW6RCiX41uJJlZSQ2j9XFDKAA0bmVU6fYrngDfM6+a8lpNGDpFTO0NNN0rQtAT0SXdhfv3GQwYVmMJe/D/C9iVOyaOHc94XlL/MAoXBnKUmxuQcZOanQS3pB71bXBnD0MSItyUyuJ1bgWIILgzHFXIwOuZIO/Y/MR2yie15TTBTYM2tb+zYP4Kaf4cfhnnAXppaDc1tNSDTn1Rk+d+euJQcAALjflLdEspLfYcF2mwE1XGY5sw4R81+snZgR X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(6072148);SRVR:MWHPR07MB3215;BCL:0;PCL:0;RULEID:;SRVR:MWHPR07MB3215; X-Microsoft-Exchange-Diagnostics: 1;MWHPR07MB3215;4:DIT6zmeb1qulo5VJXyAwEAr2Lii47kM+BghQz2ezGqS+XHvf7MDJSj+jbR+QHhnIMq4p5teLGqMmD1jri1wNWraIca3CU2ZyF7KYrhz7zNi1Y+HAsgKS4LVKtFtqsGtfmPcOVmKXuOLuaj3BuMYq77RqA+6SWf09Em0v4flzy+3H9bAKeGqdvZ0rkVzxPSSkKFjrDoGGzaNT8UL6yS5paEs3YkN43JAu8k2u83RODyeWal+t6Y5ORTSazDsoyDQuhomVizC0di4EIkjcs8Fvj7Oql2PIg3CUz0MgkwDhUoynnkHfVoql7Z0XJZsbzoO0X83LBOhKPP413oeo3sMolISDYMC7MH2zJKh/h58cqLNpWAUSgmqjB0T+qlgfApR/YOnkUgeqTavnSum2xjKC8n6D6B0i3gtbhH5sXlD+u01pVSTowdaZsLXjEK+sbGp0NeEojjZaS3fA3IzidLiiceTS3008KFcKNBWvmkMQqBGaT2JZnY37vSFC7J5hgHpW6T3vvsLkAj24/4PRHpLGiPMez4DXPVXxqLVg/JvmhKicAhsuxXdgcy88sdRYP5VIwk4LIL2iAHOXUlug65fhfbwYFGcVJrjH6XoTXucOrAKcwyXdah68gG7OTYRDxJ+JVoTVxH5k0/FQdClfGnKNxfLihbgVu0lGmtQhaCmQgIRA/j2wJLVifi2To3vqc+KSCRuHPUFAlAgyFkUDdpV7ww== X-Forefront-PRVS: 027578BB13 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(39400400002)(39410400002)(39850400002)(39450400003)(39840400002)(377454003)(24454002)(230700001)(90366009)(3846002)(6116002)(5660300001)(65826007)(2906002)(54356999)(76176999)(50466002)(23746002)(50986999)(229853002)(47776003)(7736002)(6486002)(77096006)(6666003)(33646002)(86362001)(6636002)(31686004)(42186005)(4326008)(2950100002)(189998001)(305945005)(66066001)(65956001)(36756003)(54906002)(31696002)(38730400002)(25786009)(53546009)(8676002)(6246003)(53936002);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR07MB3215;H:[10.0.0.4];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;MWHPR07MB3215;23:kgEwv7hq1QwzazjnBYjJEwYNtGoN/uKnKSgQo?= =?Windows-1252?Q?X2P4fFn+QSF0BVTmN1R91ztSAPfjwZDRkd7+yvQ8IbLaKM3+6NZlZJ8v?= =?Windows-1252?Q?LrIPLJ9rSRp747e9XScmHjTEj38DZtDFbiSJTuEAThdQDWuJnQPtiAn0?= =?Windows-1252?Q?7msSXpAHJFwaHqK/l3PG6/03tEXHwyAQ8MVgZ5daEuobtQILAld+bX1/?= =?Windows-1252?Q?UmAuYKeGOwq939mBPxGVUqz5FO/UL1a7cVqjfKPq83kegt+t2v6MkvY2?= =?Windows-1252?Q?otN4UDluOoILOt9yfDdjahqehgLNQxqi5IANccZ1UIrZUqTtXMkdxTWJ?= =?Windows-1252?Q?ut3F0P1cvf96wED9DeunzyMzlJvFkvSqFm3DaWra5HzrWRSskL0nBc5c?= =?Windows-1252?Q?sEYru8lSgyx5FfIibUm4s4L+QqZD8WvilLYT+0MqNkqpJcTtr5MUhrc5?= =?Windows-1252?Q?RAcArHXurvH1ACu0wWS+LCqv9RCDq2jliXckaElbiTXN60CSuspbUtQg?= =?Windows-1252?Q?EVTIEk0RjGRtdaQcyCqP3ziE3lfz1Y8gM2GUn9Y+L9LCHp8B5aX13GjA?= =?Windows-1252?Q?mQqKaUJccZi2i8qSgJRz5AUsTLdEtRlH8wklac0O4UO1OGFZcvEymV+w?= =?Windows-1252?Q?qfcyh5EyTJkHSAtwocElaSwNEVrQMcLjI0+pAs1WpO4+zYN2UyzsjX5+?= =?Windows-1252?Q?x02y11+p2gwKZjMulF2Fxf+QsF5KA6Azrww3qIyCZTuf4sGPrb6twdEE?= =?Windows-1252?Q?ze0/6mgY3mpVGU+NCgE8im+t8Z2R8JJdd0FlD/Eg5fTfqrE1zsxx6Old?= =?Windows-1252?Q?jy9N+YL2zDM5zqyccSmoIzgDAhbZwCBMNtGzNOHsY7HZVfaFwZXLdJz2?= =?Windows-1252?Q?DUHBxeiRJNAwpZ6O7zgD/LAaD5ZADW/1/6dEUe4wrv2iz1yCOP6UXrTw?= =?Windows-1252?Q?BvFS/bzbIwafCVGA4Z8h9V5slnldhwnWWI3jLsIAxlcMqCO2CbzXuMkA?= =?Windows-1252?Q?iDMw/NCz26JifOdAchyA1hchbMR7is+T9zAxcqHlTd+Wdq23Pf0RmEBx?= =?Windows-1252?Q?KHLAUvYEJYNAyhoKgf6J6vrM5P0WIK+Gp681/rZpaCNxLYlSw+VIKbYF?= =?Windows-1252?Q?Fig8Z4iV6lIBMCsDUFjUnnrppw21ePrWRUXzLhTJR2qpfZAeyqVMS7Ra?= =?Windows-1252?Q?hvKTbUuLVs266XXELBiAWW1YiG2cZG3imlVPZixbcThZ4AzMqq7Q83ac?= =?Windows-1252?Q?3iggdcqkH6KaH7yFTcjIOfNHMmy93a1Bk6AARM=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR07MB3215;6:4YfEvNMns6UzMJ9BchCcRFxrRYiimkewqGgR0+SsgSRkuzPhn+jUhsjJdwQGAZ7Dg0r91LptQAvU2XkIUGb/v3aufLC5mKtrJAUAmOHxoeMUmtK/U7kCa8cdaiXVi4DTAV/7zlZqIguipEpZAjbHt3tLu6OxCQCzd2Liaf3s+S61iw/ahths7CaqH9KJ3EBQPpH/Kwot+c+BoVQF3973QuiiO6vm140AJHRVpMXqLw2hJLItGDi0c9egwcoS4+Zf0QTLPtzqzFN0Bp+0ktwUPdzeiiVec7ouljw40v8iPJNNByBj2tvZuDoEG4HwLtVvHn49hBNMnB2OyeESvstwCbV8pKsULLEVydB4q/BHS5HeXG2n0E6iz2bhGUJ2nzAlURr/xh28Jq/hB3MdtJiWnBvBfgwthTEJXWOFypGGWEDzmSst+i0jbW8K4Joa3fvdZRdL0ldOWjoFte24mfzA3A==;5:Cv5kDUVJvGw+mNuv5r9GsWcRKupS2fmNlMduQ9ZQoMZuKm+JX97poXJnQN4q0fpNPO8UgeXMxJs3fkaKeGvxKOvPwvf0Gy/NY4EVG9JZe6ZnRg1+8iAY4e0MSepSsQFM6PNOFsAXQAlFh6pGxOHfNw==;24:HsoHWfWOMIo8zPG/RztqsHj8fhtD0vXTRFVdswpc2Qu3syesKn38y9/gv6wxWQ+RUElFvfMQ5Oc2X/0OX7bgzsGcP+cDGk1tD1uBKr45bUA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR07MB3215;7:GBmp22TUI/yF9VvCFIJ0mc8ec1bKAGwa/VB0j9Tfz+nPEd4WfJ69GC+5OaDkC+OHMdFA6iqALgT64j1J1a6Xiy+0ZozQxuTezMBqYJcTEX4oP22+TUKrY2MYA+jREQa3uPTI1k9H50bWnyiuG+nR4Fobhr9I0cS/bWRQ7sRHdgwe3yye2ahTdHxfy230bgS37Eyh2zB7jHGQIBtwX+al7nrt4Z8vJLzsKxkzuG9XM1If8GijsS8qB8SIqNy00R3rcW6R71qDS9TleqeuluhSGFSgcWlj5RS+O96Jz2qtjWbdc+IibJLCOkVpMnJZC7BDFXXOgSzKGW0eXv8RqI+fIw== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2017 23:21:36.2085 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3215 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 834 Lines: 19 On 04/12/2017 05:37 PM, Aaro Koskinen wrote: > > Please rather post a new version that also works with OCTEON. I don't > think a partial driver should be merged; originally this driver was > working fine with OCTEON so there should be no issue supporting that?! > Hey Aaro. The difference is that Jan added scatter/gather support to take advantage of the DMA FIFOs on Thunder. The same FIFOs exist on Octeon parts 73xx, 76xx, 78xx, CNF73xx, and CNF75xx to name a few. In order to support those, portions of the Octeon platform code had to be rewritten as well as minor changes in the core Cavium driver code. I have a fully tested patchset that cleanly applies on top of Jan's v13 driver. My personal preference is for the Octeon code to be a separate patch. I will defer that decision to Jan, David and the MMC maintainers. Steve