Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755732AbdDMFZ5 (ORCPT ); Thu, 13 Apr 2017 01:25:57 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:37933 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751439AbdDMFZz (ORCPT ); Thu, 13 Apr 2017 01:25:55 -0400 Date: Thu, 13 Apr 2017 15:24:50 +1000 From: Gavin Shan To: Alex Williamson Cc: bodong@mellanox.com, helgaas@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, saeedm@mellanox.com, Eli Cohen , gwshan@linux.vnet.ibm.com Subject: Re: [v3] PCI: Add an option to control probing of VFs before enabling SR-IOV Reply-To: Gavin Shan References: <1492037500-84654-1-git-send-email-bodong@mellanox.com> <20170412205614.429db99c@t450s.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170412205614.429db99c@t450s.home> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-MML: disable x-cbid: 17041305-0040-0000-0000-00000306B337 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17041305-0041-0000-0000-00000C7E7032 Message-Id: <20170413052450.GA32407@gwshan> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-13_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704130043 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1800 Lines: 43 On Wed, Apr 12, 2017 at 08:56:14PM -0600, Alex Williamson wrote: >On Thu, 13 Apr 2017 01:51:40 +0300 >bodong@mellanox.com wrote: > >> From: Bodong Wang >> >> Sometimes it is not desirable to probe the virtual functions after >> SRIOV is enabled. This can save host side resource usage by VF >> instances which would be eventually probed to VMs. >> >> Add a new PCI sysfs interface "sriov_drivers_autoprobe" to control >> that from the PF, all current callers still retain the same >> functionality. To modify it, echo 0/n/N (disable probe) or 1/y/Y >> (enable probe) to: >> >> /sys/bus/pci/devices//sriov_drivers_autoprobe >> >> Note that, the choice must be made before enabling VFs. The change >> will not take effect if VFs are already enabled. Simply, one can set >> sriov_numvfs to 0, choose whether to probe or not, and then resume >> sriov_numvfs. >> >> Signed-off-by: Bodong Wang >> Signed-off-by: Eli Cohen >> Reviewed-by: Gavin Shan >> Reviewed-by: Alex Williamson > >Whoa, I reviewed the last version, that's different than providing a >Reviewed-by, and I've certainly never seen this version until now, so I >can't possibly have endorsed it in any way. It's also changed since >Gavin saw it and I think Bjorn is in the same boat. Probably a good >idea to cc the people you're claiming reviewed this too (cc +Gavin). > Thanks, Alex. I usually keep an eye on the patches that I ever reviewed and follow them until they are merged or rejected. More comments would be given if I have. Otherwise, everthing is fine. Yes, it's always nice to copy those who reviewed the patch. For this one, my reviewed-by is still valid. Thanks, Gavin