Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756272AbdDMJO3 (ORCPT ); Thu, 13 Apr 2017 05:14:29 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:47101 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750811AbdDMJO1 (ORCPT ); Thu, 13 Apr 2017 05:14:27 -0400 Date: Thu, 13 Apr 2017 11:14:18 +0200 From: Peter Zijlstra To: "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com Subject: Re: [PATCH tip/core/rcu 02/13] lockdep: Use "WARNING" tag on lockdep splats Message-ID: <20170413091418.ok342icfii6dkvjc@hirez.programming.kicks-ass.net> References: <20170412165441.GA17149@linux.vnet.ibm.com> <1492016149-18834-2-git-send-email-paulmck@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1492016149-18834-2-git-send-email-paulmck@linux.vnet.ibm.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1610 Lines: 35 On Wed, Apr 12, 2017 at 09:55:38AM -0700, Paul E. McKenney wrote: > This commit changes lockdep splats to begin lines with "WARNING" and > to use pr_warn() instead of printk(). This change eases scripted > analysis of kernel console output. > > Reported-by: Dmitry Vyukov > Reported-by: Ingo Molnar > Signed-off-by: Paul E. McKenney > Acked-by: Dmitry Vyukov > --- > kernel/locking/lockdep.c | 86 +++++++++++++++++++++--------------------- > kernel/locking/rtmutex-debug.c | 9 +++-- > 2 files changed, 48 insertions(+), 47 deletions(-) > > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c > index a95e5d1f4a9c..e9d4f85b290c 100644 > --- a/kernel/locking/lockdep.c > +++ b/kernel/locking/lockdep.c > @@ -1144,10 +1144,10 @@ print_circular_bug_header(struct lock_list *entry, unsigned int depth, > return 0; > > printk("\n"); > - printk("======================================================\n"); > - printk("[ INFO: possible circular locking dependency detected ]\n"); > + pr_warn("======================================================\n"); > + pr_warn("WARNING: possible circular locking dependency detected\n"); > print_kernel_ident(); > - printk("-------------------------------------------------------\n"); > + pr_warn("------------------------------------------------------\n"); > printk("%s/%d is trying to acquire lock:\n", > curr->comm, task_pid_nr(curr)); > print_lock(check_src); Blergh, not a fan of this patch. Now we have an odd mix of pr_crap() and printk().