Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753522AbdDMMMj (ORCPT ); Thu, 13 Apr 2017 08:12:39 -0400 Received: from mx2.suse.de ([195.135.220.15]:35485 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751473AbdDMMMh (ORCPT ); Thu, 13 Apr 2017 08:12:37 -0400 Date: Thu, 13 Apr 2017 14:12:16 +0200 From: Borislav Petkov To: "Luck, Tony" Cc: Thomas Gleixner , Dan Williams , "Verma, Vishal L" , "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" , "ross.zwisler@linux.intel.com" , "x86@kernel.org" Subject: Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from 'atomic' Message-ID: <20170413121215.kzflalrar7hpxvjh@pd.tnic> References: <1492028744.2738.14.camel@intel.com> <20170412205229.GA13659@intel.com> <20170412211931.GA15771@intel.com> <20170412214749.jyt7cmyhovivtb2m@pd.tnic> <20170412221639.5klmqk4mjbvy6btx@pd.tnic> <20170412222619.GA17839@intel.com> <20170412222925.r3izasv3yuyjy62e@pd.tnic> <20170413113159.rc32ebiswn64nzrr@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170413113159.rc32ebiswn64nzrr@pd.tnic> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 693 Lines: 28 On Thu, Apr 13, 2017 at 01:31:59PM +0200, Borislav Petkov wrote: > @@ -321,18 +321,8 @@ static void __print_mce(struct mce *m) > > static void print_mce(struct mce *m) > { > - int ret = 0; > - > __print_mce(m); > - > - /* > - * Print out human-readable details about the MCE error, > - * (if the CPU has an implementation for that) > - */ > - ret = atomic_notifier_call_chain(&x86_mce_decoder_chain, 0, m); > - if (ret == NOTIFY_STOP) > - return; > - > + mce_log(m); Actually, we don't need that call here because do_machine_check() already does it. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --