Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753174AbdDMNIX (ORCPT ); Thu, 13 Apr 2017 09:08:23 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:57119 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751088AbdDMNIS (ORCPT ); Thu, 13 Apr 2017 09:08:18 -0400 Date: Thu, 13 Apr 2017 06:08:15 -0700 From: Guenter Roeck To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, Jean Delvare Subject: Re: [v2,1/2] hwmon: (lm87) Remove unused I2C devices driver_data Message-ID: <20170413130815.GA23462@roeck-us.net> References: <20170413002139.5983-1-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170413002139.5983-1-javier@osg.samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1127 Lines: 43 On Wed, Apr 12, 2017 at 09:21:38PM -0300, Javier Martinez Canillas wrote: > The I2C device ID entries set a .driver_data but this data is never > looked up by the driver. So don't set it and also remove the enum. > > Signed-off-by: Javier Martinez Canillas Applied. Thanks, Guenter > --- > > Changes in v2: > - Use the correct driver in subject line. > > drivers/hwmon/lm87.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/hwmon/lm87.c b/drivers/hwmon/lm87.c > index 04a7a1ddb030..c0766e7392d3 100644 > --- a/drivers/hwmon/lm87.c > +++ b/drivers/hwmon/lm87.c > @@ -75,8 +75,6 @@ > > static const unsigned short normal_i2c[] = { 0x2c, 0x2d, 0x2e, I2C_CLIENT_END }; > > -enum chips { lm87, adm1024 }; > - > /* > * The LM87 registers > */ > @@ -981,8 +979,8 @@ static int lm87_probe(struct i2c_client *client, const struct i2c_device_id *id) > */ > > static const struct i2c_device_id lm87_id[] = { > - { "lm87", lm87 }, > - { "adm1024", adm1024 }, > + { "lm87", 0 }, > + { "adm1024", 0 }, > { } > }; > MODULE_DEVICE_TABLE(i2c, lm87_id);