Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753166AbdDMQ1C (ORCPT ); Thu, 13 Apr 2017 12:27:02 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:55633 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751495AbdDMQ1A (ORCPT ); Thu, 13 Apr 2017 12:27:00 -0400 Date: Thu, 13 Apr 2017 09:26:51 -0700 From: "Paul E. McKenney" To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com, Will Deacon , Boqun Feng , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH tip/core/rcu 02/40] rcu: Make arch select smp_mb__after_unlock_lock() strength Reply-To: paulmck@linux.vnet.ibm.com References: <20170412174003.GA23207@linux.vnet.ibm.com> <1492018825-25634-2-git-send-email-paulmck@linux.vnet.ibm.com> <20170413092418.a2rudzukbgookior@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170413092418.a2rudzukbgookior@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17041316-0040-0000-0000-00000314F613 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006929; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000208; SDB=6.00847059; UDB=6.00417881; IPR=6.00625492; BA=6.00005288; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015033; XFM=3.00000013; UTC=2017-04-13 16:26:55 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17041316-0041-0000-0000-00000709021D Message-Id: <20170413162651.GD3956@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-13_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704130138 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1298 Lines: 25 On Thu, Apr 13, 2017 at 11:24:18AM +0200, Peter Zijlstra wrote: > On Wed, Apr 12, 2017 at 10:39:47AM -0700, Paul E. McKenney wrote: > > The definition of smp_mb__after_unlock_lock() is currently smp_mb() > > for CONFIG_PPC and a no-op otherwise. It would be better to instead > > provide an architecture-selectable Kconfig option, and select the > > strength of smp_mb__after_unlock_lock() based on that option. > > Why is this better? Do we want to have more of this? I thought we still > wanted to convince PPC to go RCsc and eradicate all this RCpc 'fun'. But > instead now you're making it look like its OK to grow more of this pain. ARCH_WEAK_RELEASE_ACQUIRE actually works both ways. To see this, imagine some strange alternate universe in which the Power hardware guys actually did decide to switch PPC to doing RCsc as you suggest. There would still be a lot of Power hardware out there that still does RCpc. Therefore, powerpc builds that needed to run on old Power hardware would select ARCH_WEAK_RELEASE_ACQUIRE, while kernels built to run only on the shiny new (but mythical) alternate-universe Power hardware would avoid selecting this Kconfig option. But the real reason I queued this patch is that Ingo asked me for it: https://lkml.org/lkml/2017/1/14/88 Thanx, Paul