Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753622AbdDMRRA (ORCPT ); Thu, 13 Apr 2017 13:17:00 -0400 Received: from anholt.net ([50.246.234.109]:37790 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752537AbdDMRQ5 (ORCPT ); Thu, 13 Apr 2017 13:16:57 -0400 From: Eric Anholt To: Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/5] drm/vc4: Expose dma-buf fences for V3D rendering. In-Reply-To: <20170413071311.w7chpkyvh2kodh45@phenom.ffwll.local> References: <20170412191202.22740-1-eric@anholt.net> <20170412191202.22740-6-eric@anholt.net> <20170413071311.w7chpkyvh2kodh45@phenom.ffwll.local> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Thu, 13 Apr 2017 10:16:54 -0700 Message-ID: <87y3v4b52x.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2005 Lines: 47 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Daniel Vetter writes: > On Wed, Apr 12, 2017 at 12:12:02PM -0700, Eric Anholt wrote: >> This is needed for proper synchronization with display on another DRM >> device (pl111 or tinydrm) with buffers produced by vc4 V3D. Fixes the >> new igt vc4_dmabuf_poll testcase, and rendering of one of the glmark2 >> desktop tests on pl111+vc4. >>=20 >> This doesn't yet introduce waits on other device's fences before vc4's >> rendering/display, because I don't have testcases for them. >>=20 >> v2: Reuse dma_fence_free(), retitle commit message to clarify that >> it's not a full dma-buf fencing implementation yet. >>=20 >> Signed-off-by: Eric Anholt > > Double-checked a few things in your ww_mutex scheme, seems are correct. > And testing with CONFIG_DEBUG_WW_MUTEX_SLOWPATH should catch any kind of > fumbles in your error paths. I didnt do a full review, so just Yeah, the lockdep and WW debug options were incredibly useful (and I should probably go turn them off now). --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAljvsocACgkQtdYpNtH8 nuhIFxAAouRMQ+BMBdeFvCZ+3FrJWkVparW7C3PZf6ZBaf8mlQ9cB0gqn5pblWCU 5DhuTqAXafcxPkINrc4L6b9hp2q9Oqy85KqojuacPy7fh5INeSpp+osbNE9PwF20 yijt04OMEjAUYDPSQdGTiftTimPy3yxMkMe0TXLKACfOEWoE/hDWMlQ14JDoaBmU ExjwEWw2ggRIADlhl1sDt7k6BPf1K8Lvlh+6smfe4VbpVTJs868fxJf09EwBgvpO lgEyR7KWCQJ70DnCe/28FLi3uZwNZZ/oI8xy6aircoojmg6XWavoJvJH/44Tdpmh Eqhk4osFhldR2FjwdZ3mgG8vrkMqpc2JOuY8QfPtQx37S3wNFzjbKemLJNUrRisV 920sM0Cn2ZUpH1QEIhi+gbgPV2BQFaFFEFO4mpC3YZtSFFupPedctNlTsk6HdgPA sALaRQRDx6/C5bhsgJ16A58nCn6KnJLC1rZ6BdUL/B9mNwRfkeKnHt1x0W8p4sIu sXYunybKdhtoKA0day7IWB98S/UbfO+SifYO3QpuPZi8mQOHXJ15FbgsxDsXgcSP xsqt7y8s9htdoa3nxSf59V+ygBKOMCKtrminyv1ZDjjtkVPkqOwC8gC+N887WTYV x3XOIs159vlD72RN0TzT6dAj5UzwgBg6mf0jMeN2jRWA/7TiOHA= =GBMN -----END PGP SIGNATURE----- --=-=-=--