Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755180AbdDMSBt (ORCPT ); Thu, 13 Apr 2017 14:01:49 -0400 Received: from anholt.net ([50.246.234.109]:38100 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753261AbdDMSBq (ORCPT ); Thu, 13 Apr 2017 14:01:46 -0400 From: Eric Anholt To: Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/5] drm/vc4: Expose dma-buf fences for V3D rendering. In-Reply-To: <20170413071311.w7chpkyvh2kodh45@phenom.ffwll.local> References: <20170412191202.22740-1-eric@anholt.net> <20170412191202.22740-6-eric@anholt.net> <20170413071311.w7chpkyvh2kodh45@phenom.ffwll.local> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Thu, 13 Apr 2017 11:01:44 -0700 Message-ID: <87vaq8425z.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2058 Lines: 49 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Daniel Vetter writes: > On Wed, Apr 12, 2017 at 12:12:02PM -0700, Eric Anholt wrote: >> This is needed for proper synchronization with display on another DRM >> device (pl111 or tinydrm) with buffers produced by vc4 V3D. Fixes the >> new igt vc4_dmabuf_poll testcase, and rendering of one of the glmark2 >> desktop tests on pl111+vc4. >>=20 >> This doesn't yet introduce waits on other device's fences before vc4's >> rendering/display, because I don't have testcases for them. >>=20 >> v2: Reuse dma_fence_free(), retitle commit message to clarify that >> it's not a full dma-buf fencing implementation yet. >>=20 >> Signed-off-by: Eric Anholt > > Double-checked a few things in your ww_mutex scheme, seems are correct. > And testing with CONFIG_DEBUG_WW_MUTEX_SLOWPATH should catch any kind of > fumbles in your error paths. I didnt do a full review, so just > > Acked-by: Daniel Vetter The two other most likely reviewers (ickle and padovan) have at least glanced at it, so I've pushed it now. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAljvvQgACgkQtdYpNtH8 nui41RAAl0cAH/SCkkeWoigXn9POOyzZMWHm3qx5NvVQibr48/xnxkvn2f2axoi8 zlU1LEm90RTguplb2bE9dBh2q05yucmXYb7f9EQwB2d+HndUmrJawwLiRx5ec5V3 guqiei89RBXPsftRKmQ+KFTGweA34vpZ3QjkpTQ96381W5IF+shmZCO/eAzeDbG8 BQOG907V+3iVrEebESzqLg57Dddo2hzpWhBMM32GRHYcij5c7NmxSUfhcBTwbsy3 mVxxDPsbK/bWo5/yaCrFdAQ4HF367he5fT79UQyQ91Xp0gPdY5S6lBq8OxpQLhxz wRl7ppXxDEHEXU9V8ABz5yLczM1QAbvbgwXxPj1sIFeEv1m1m27joxxELGySFIJE EvoaoAQ6sngtV3uN90Kj/6kfLCF2ZLyz9Wr02KLFD0j/wkUqlKqSQnRAq29MgciC MjniK6otRy6iw2vxS9CpF6K2DuNXVYjghUAreQ+KwxuIv55tB1Xd946O7v6trAJk lFM/pCi8K7SC67VM/Ng8RmhMz3CKh2yP89Biyu2ob346sSXi24XOppFVdch2quTz xU/oRiQrVoYtzO++QpIuqE5KuPs5Iy+17bXjreL/hBsg5juLgvDu72ZyhbYYMHpW n8q0lJ2GfMK7SKSkPjoLF641pLk1kkBktM7Em3PV8eMj3TRGuaM= =Tu15 -----END PGP SIGNATURE----- --=-=-=--