Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755279AbdDMSGY (ORCPT ); Thu, 13 Apr 2017 14:06:24 -0400 Received: from merlin.infradead.org ([205.233.59.134]:54254 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752698AbdDMSGV (ORCPT ); Thu, 13 Apr 2017 14:06:21 -0400 Date: Thu, 13 Apr 2017 20:06:12 +0200 From: Peter Zijlstra To: Vincent Guittot Cc: Ingo Molnar , linux-kernel , Dietmar Eggemann , Morten Rasmussen , Yuyang Du , Paul Turner , Ben Segall Subject: Re: [PATCH v2] sched/fair: update scale invariance of PELT Message-ID: <20170413180612.hzji6hz2q4iwxcoz@hirez.programming.kicks-ass.net> References: <20170410173802.orygigjbcpefqtdv@hirez.programming.kicks-ass.net> <20170411075221.GA30421@linaro.org> <20170411085305.aik6gdy6n3wa22ok@hirez.programming.kicks-ass.net> <20170411094021.GA17811@linaro.org> <20170411104136.33hkvzlmoa7zc72l@hirez.programming.kicks-ass.net> <20170411104949.eat4o37rlqiiobeu@hirez.programming.kicks-ass.net> <20170411130920.GB22895@linaro.org> <20170412112858.75hg75sd3clfxvvk@hirez.programming.kicks-ass.net> <20170413133205.jbf25sptwyldfvih@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 639 Lines: 16 On Thu, Apr 13, 2017 at 04:59:15PM +0200, Vincent Guittot wrote: > On 13 April 2017 at 15:32, Peter Zijlstra wrote: > > On Wed, Apr 12, 2017 at 01:28:58PM +0200, Peter Zijlstra wrote: > > > >> I still wonder about the whole !running vs !weight thing., > > > > Ah, since we use this for both util _and_ load, we need !running && > > !weight, and it so happens that !weight implies !running. Is that it? > > exactly > sorry, I should have started with that Damn, that just bring me around to wondering why running is the right condition to create lost-time. Because for runnable we want everything that has weight.