Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755548AbdDMTDs (ORCPT ); Thu, 13 Apr 2017 15:03:48 -0400 Received: from mail-io0-f179.google.com ([209.85.223.179]:35977 "EHLO mail-io0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753063AbdDMTDn (ORCPT ); Thu, 13 Apr 2017 15:03:43 -0400 MIME-Version: 1.0 In-Reply-To: <20170413133242.5068-5-andrew.smirnov@gmail.com> References: <20170413133242.5068-1-andrew.smirnov@gmail.com> <20170413133242.5068-5-andrew.smirnov@gmail.com> From: Tyler Baker Date: Thu, 13 Apr 2017 12:03:41 -0700 Message-ID: Subject: Re: [PATCH 4/8] ARM: dts: imx7s: Add node for GPC To: Andrey Smirnov Cc: Shawn Guo , yurovsky@gmail.com, Sascha Hauer , Fabio Estevam , Rob Herring , Mark Rutland , Russell King , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-arm-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2175 Lines: 56 Hi Andrey, On 13 April 2017 at 06:32, Andrey Smirnov wrote: > Add node for GPC and specify as a parent interrupt controller for SoC bus. > > Cc: yurovsky@gmail.com > Cc: Sascha Hauer > Cc: Fabio Estevam > Cc: Rob Herring > Cc: Mark Rutland > Cc: Russell King > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Andrey Smirnov > --- > arch/arm/boot/dts/imx7s.dtsi | 27 ++++++++++++++++++++++++++- > 1 file changed, 26 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi > index 8fee299..1a7058f 100644 > --- a/arch/arm/boot/dts/imx7s.dtsi > +++ b/arch/arm/boot/dts/imx7s.dtsi > @@ -42,6 +42,7 @@ > */ >[0 > #include > +#include > #include > #include > #include > @@ -119,7 +120,7 @@ > #address-cells = <1>; > #size-cells = <1>; > compatible = "simple-bus"; > - interrupt-parent = <&intc>; > + interrupt-parent = <&gpc>; I've been testing your GPC/PCIe patch sets against v4.11-rc5 on my imx7d-cl-som-imx7, but hit a bit of a wall. When gpc is set as the interrupt-parent for the soc, the kernel seems to hang and not produce any output on the serial port[0]. I tried to enable earlyprintk, but no luck getting a trace. Reversing this change, gets the board booting[1], but obviously isn't using the gpc which is needed for PCIe support as I understand it. I assume you've tested these changes on a imx7d-sdb and are not seeing a similar issue? You can find the patches I've picked on top of v4.11-rc5 here[2], any idea what might be the issue? Cheers, Tyler [0] https://hastebin.com/zetohetuwi.coffeescript [1] https://hastebin.com/uvacuyicuh.sql [2] https://github.com/EmbeddedAndroid/linux/commits/tracking-ltd-imx-dev