Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752908AbdDMVHN (ORCPT ); Thu, 13 Apr 2017 17:07:13 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:41961 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751626AbdDMVHJ (ORCPT ); Thu, 13 Apr 2017 17:07:09 -0400 Date: Thu, 13 Apr 2017 14:07:07 -0700 From: Guenter Roeck To: Rob Herring Cc: Moritz Fischer , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, lee.jones@linaro.org, olof@lixom.net, jdelvare@suse.com, mark.rutland@arm.com, Moritz Fischer Subject: Re: [PATCH 2/3] dt-bindings: hwmon: Add bindings for Google Chromium EC HWMON Message-ID: <20170413210707.GA16304@roeck-us.net> References: <1491602410-31518-1-git-send-email-moritz.fischer@ettus.com> <1491602410-31518-2-git-send-email-moritz.fischer@ettus.com> <20170413200140.lcynmsv255ktoiyl@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170413200140.lcynmsv255ktoiyl@rob-hp-laptop> User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2192 Lines: 55 On Thu, Apr 13, 2017 at 03:01:40PM -0500, Rob Herring wrote: > On Fri, Apr 07, 2017 at 03:00:09PM -0700, Moritz Fischer wrote: > > From: Moritz Fischer > > > > Add bindings for the Chromium EC HWMON. The Chromium EC HWMON > > allows monitoring of temperature sensors and fans attached to the > > EC. > > > > Signed-off-by: Moritz Fischer > > --- > > .../devicetree/bindings/hwmon/cros-ec-hwmon.txt | 25 ++++++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/hwmon/cros-ec-hwmon.txt > > > > diff --git a/Documentation/devicetree/bindings/hwmon/cros-ec-hwmon.txt b/Documentation/devicetree/bindings/hwmon/cros-ec-hwmon.txt > > new file mode 100644 > > index 0000000..4c94869 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/hwmon/cros-ec-hwmon.txt > > @@ -0,0 +1,25 @@ > > +Chromium Embedded Controller EC temperature and fan control > > +----------------------------------------------------------- > > + > > +Google's Chromium EC HWMON is a hwmon implemented byimplemented by the Chromium EC > > +firmware attached to the Embedded Controller (EC) and controlled via a host-command > > +interface. > > + > > +An EC HWMON node should be only found as a sub-node of the EC node (see > > +Documentation/devicetree/bindings/mfd/cros-ec.txt). > > + > > +Required properties: > > +- compatible: Must contain "google,cros-ec-hwmon" > > + > > +Example: > > + embedded-controller@1e { > > + reg = <0x1e>; > > + compatible = "google,cros-ec-i2c"; > > + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > > + interrupt-parent = <&gpio0>; > > + > > + hwmon { > > + compatible = "google,cros-ec-hwmon"; > > This is sufficient for all devices? I don't see that DT provides > anything here other than instantiating a device, but the parent device > can just as easily do that. > The parent driver (drivers/mfd/cros_ec_i2c.c) calls cros_ec_register(), which uses uses of_platform_populate() to populate all sub-devices. There are various examples in the dts files (look for "google,cros-ec"). Does it really make sense to start a second method for instantiating sub-devices ? Thanks, Guenter