Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751503AbdDMVT6 (ORCPT ); Thu, 13 Apr 2017 17:19:58 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:36556 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750735AbdDMVTz (ORCPT ); Thu, 13 Apr 2017 17:19:55 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170413133242.5068-1-andrew.smirnov@gmail.com> <20170413133242.5068-5-andrew.smirnov@gmail.com> From: Andrey Smirnov Date: Thu, 13 Apr 2017 14:19:54 -0700 Message-ID: Subject: Re: [PATCH 4/8] ARM: dts: imx7s: Add node for GPC To: Tyler Baker Cc: Shawn Guo , Andrey Yurovsky , Sascha Hauer , Fabio Estevam , Rob Herring , Mark Rutland , Russell King , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-arm-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2714 Lines: 65 On Thu, Apr 13, 2017 at 12:03 PM, Tyler Baker wrote: > Hi Andrey, > > On 13 April 2017 at 06:32, Andrey Smirnov wrote: >> Add node for GPC and specify as a parent interrupt controller for SoC bus. >> >> Cc: yurovsky@gmail.com >> Cc: Sascha Hauer >> Cc: Fabio Estevam >> Cc: Rob Herring >> Cc: Mark Rutland >> Cc: Russell King >> Cc: devicetree@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Cc: linux-arm-kernel@lists.infradead.org >> Signed-off-by: Andrey Smirnov >> --- >> arch/arm/boot/dts/imx7s.dtsi | 27 ++++++++++++++++++++++++++- >> 1 file changed, 26 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi >> index 8fee299..1a7058f 100644 >> --- a/arch/arm/boot/dts/imx7s.dtsi >> +++ b/arch/arm/boot/dts/imx7s.dtsi >> @@ -42,6 +42,7 @@ >> */ >>[0 >> #include >> +#include >> #include >> #include >> #include >> @@ -119,7 +120,7 @@ >> #address-cells = <1>; >> #size-cells = <1>; >> compatible = "simple-bus"; >> - interrupt-parent = <&intc>; >> + interrupt-parent = <&gpc>; > > I've been testing your GPC/PCIe patch sets against v4.11-rc5 on my > imx7d-cl-som-imx7, but hit a bit of a wall. When gpc is set as the > interrupt-parent for the soc, the kernel seems to hang and not produce > any output on the serial port[0]. I tried to enable earlyprintk, but > no luck getting a trace. Reversing this change, gets the board > booting[1], but obviously isn't using the gpc which is needed for PCIe > support as I understand it. I assume you've tested these changes on a > imx7d-sdb and are not seeing a similar issue? You can find the patches > I've picked on top of v4.11-rc5 here[2], any idea what might be the > issue? Hmm, this is something new and I don't think I've seen it(neither that nor the backtrace from your following e-mail). Here's the kernel tree as I've been testing it: https://github.com/ndreys/linux/commits/imx7d/pcie-support-v8 note, however, that it is based on d0ec4e6 (tip of pci/next when I was rebasing) of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git, which is not exactly v4.11-rc5 I'll rebase on top v4.11-r5 and see if I can get the same backtrace you are getting and see if I can fix it. Thanks and sorry for breaking things for you, Andrey Smirnov