Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752537AbdDMVV2 (ORCPT ); Thu, 13 Apr 2017 17:21:28 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:33276 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752046AbdDMVVN (ORCPT ); Thu, 13 Apr 2017 17:21:13 -0400 Date: Thu, 13 Apr 2017 23:20:59 +0200 From: Alexandre Belloni To: Javier Martinez Canillas Cc: Peter Rosin , linux-kernel@vger.kernel.org, Wolfram Sang , devicetree@vger.kernel.org, Russell King , Rob Herring , Nicolas Ferre , Mark Rutland , linux-arm-kernel@lists.infradead.org, Geert Uytterhoeven Subject: Re: [PATCH v2 05/22] ARM: dts: at91: Add generic compatible string for I2C EEPROM Message-ID: <20170413212059.unh2mfo2w4oc4t33@piout.net> References: <20170413182839.25381-1-javier@osg.samsung.com> <20170413182839.25381-6-javier@osg.samsung.com> <869a0f44-6c97-2109-776b-6da9b86c732a@axentia.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1123 Lines: 44 On 13/04/2017 at 18:09:56 -0300, Javier Martinez Canillas wrote: > Hello Peter, > > On 04/13/2017 05:43 PM, Peter Rosin wrote: > > On 2017-04-13 20:28, Javier Martinez Canillas wrote: > > [snip] > > >> > >> eeprom@50 { > >> - compatible = "nxp,24c02"; > >> + compatible = "nxp,24c02","atmel,24c02"; > >> reg = <0x50>; > >> pagesize = <16>; > >> }; > >> > > > > Sure, in principle. But not having a space after the commas is a real OCD > > trigger for me. My spine is rotating... :-) > > > > Right, Geert already pointed out. It's something I missed in my sed script > so I got it wrong in all the DTS :( > > I'll fix my script and send a v2. > That would be v3, right? ;) > > Anyway, with those whitespace fixes (and without them too, but please): > > Acked-by: Peter Rosin > > > > Thanks for the review! > I'd like to be copied on the first patches to ensure they are applied before applying that one. (Also, it is probably too late for 4.12 anyway because we are past rc6). -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com