Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752583AbdDMWxm (ORCPT ); Thu, 13 Apr 2017 18:53:42 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:36220 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751423AbdDMWxj (ORCPT ); Thu, 13 Apr 2017 18:53:39 -0400 MIME-Version: 1.0 In-Reply-To: <20170413210354.GA17134@roeck-us.net> References: <1491602410-31518-1-git-send-email-moritz.fischer@ettus.com> <20170413210354.GA17134@roeck-us.net> From: Moritz Fischer Date: Thu, 13 Apr 2017 15:53:38 -0700 Message-ID: Subject: Re: [PATCH 1/3] mfd: cros-ec: Add functions to read mapped memory To: Guenter Roeck Cc: Moritz Fischer , linux-hwmon@vger.kernel.org, Linux Kernel Mailing List , Devicetree List , Lee Jones , olof@lixom.net, jdelvare@suse.com, Rob Herring , Mark Rutland Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 838 Lines: 24 Hi Guenter, On Thu, Apr 13, 2017 at 2:03 PM, Guenter Roeck wrote: > On Fri, Apr 07, 2017 at 03:00:08PM -0700, Moritz Fischer wrote: >> From: Moritz Fischer >> >> The ChromeOS EC has mapped memory regions where things like temperature >> sensors and fan speed are stored. Provide access to those from the >> cros-ec mfd device. >> > > Turns out struct cros_ec_device already provides a cmd_readmem callback, > which is widely used by other drivers. Why don't you just use it ? This is only actually set by the lpc version of the cros_ec. I2C and SPI connected ECs emulate it. I can most certainly hook it up in the (spi,i2c) drivers, but the implementation for SPI and I2C needs to live somewhere. drivers/platform/chrome/cros_ec_proto.c seemed to be a good place. Thanks for the feedback! Moritz