Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753524AbdDMX17 (ORCPT ); Thu, 13 Apr 2017 19:27:59 -0400 Received: from mail-sn1nam01on0109.outbound.protection.outlook.com ([104.47.32.109]:23156 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753288AbdDMX14 (ORCPT ); Thu, 13 Apr 2017 19:27:56 -0400 From: KY Srinivasan To: Miguel Bernal Marin , "Martin K. Petersen" CC: "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "devel@linuxdriverproject.org" , Haiyang Zhang , Stephen Hemminger , "James E.J. Bottomley" Subject: RE: [PATCH] scsi: storvsc: Prefer kcalloc over kzalloc with multiply Thread-Topic: [PATCH] scsi: storvsc: Prefer kcalloc over kzalloc with multiply Thread-Index: AQHSniK8kWd/U46PS0OPuq5IuNiud6HEHgWQ Date: Thu, 13 Apr 2017 23:27:38 +0000 Message-ID: References: <20170316065823.13319-1-miguel.bernal.marin@linux.intel.com> In-Reply-To: <20170316065823.13319-1-miguel.bernal.marin@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linux.intel.com; dkim=none (message not signed) header.d=none;linux.intel.com; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [50.135.110.52] x-microsoft-exchange-diagnostics: 1;CY1PR03MB1421;7:759bpHJpkPRoihBCzY4LCvs2PPl0d1omn77lDTygiX+FCSt8qGb7H3Lx053IbmMy8DJI4e13PSGN0iqVTcLGQN32DquhY/CFUTYcGP/E/edY4rfRsujUTvL5niDM5zDN2r/9F79vMEryIlSIY0EXtvDksTEJULvRgu5Suix/n5C/CfnY/PrQr3PWCh28Dw0vPCHQULv7Jx38DrcOiPAwPB88inDZUfknm7T4rrnqrU3bKtpDO6xOSaihmXQAVxHCIRf8U3LIoSatEf0cFd9YL5ODZo0B+BZZUmJv28Kly8W5k4xIy9vr75Ruuig16YXvZtgt+YGgyrSeX8KSjupDh0mKVQV/ujHJyYGwkZVwYB0= x-ms-office365-filtering-correlation-id: f1349f07-f6db-410a-bba8-08d482c4acee x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:CY1PR03MB1421; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(104084551191319)(146099531331640)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(6055026)(61426038)(61427038)(6041248)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(20161123555025)(20161123562025)(6072148);SRVR:CY1PR03MB1421;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1421; x-forefront-prvs: 02760F0D1C x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39840400002)(39410400002)(39860400002)(39450400003)(39400400002)(39850400002)(13464003)(377454003)(74316002)(10090500001)(122556002)(3280700002)(38730400002)(229853002)(6506006)(2906002)(4326008)(53546009)(6246003)(189998001)(5660300001)(86362001)(50986999)(76176999)(54356999)(25786009)(6436002)(86612001)(305945005)(7736002)(2900100001)(81166006)(3660700001)(53936002)(5005710100001)(77096006)(8676002)(8990500004)(2950100002)(102836003)(55016002)(54906002)(99286003)(3846002)(7696004)(8936002)(10290500002)(33656002)(9686003)(66066001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR03MB1421;H:DM5PR03MB2490.namprd03.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2017 23:27:39.0348 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1421 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v3DNSNRV020274 Content-Length: 1526 Lines: 45 > -----Original Message----- > From: Miguel Bernal Marin [mailto:miguel.bernal.marin@linux.intel.com] > Sent: Wednesday, March 15, 2017 11:58 PM > To: KY Srinivasan ; Martin K. Petersen > > Cc: linux-kernel@vger.kernel.org; linux-scsi@vger.kernel.org; > devel@linuxdriverproject.org; Haiyang Zhang ; > Stephen Hemminger ; James E.J. Bottomley > > Subject: [PATCH] scsi: storvsc: Prefer kcalloc over kzalloc with multiply > > Use kcalloc for allocating an array instead of kzalloc with multiply, > kcalloc is the preferred API. > > Found with checkpatch. > > Signed-off-by: Miguel Bernal Marin Reviewed-by: K. Y. Srinivasan > --- > drivers/scsi/storvsc_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c > index 638e5f427c90..3d70d1cf49a3 100644 > --- a/drivers/scsi/storvsc_drv.c > +++ b/drivers/scsi/storvsc_drv.c > @@ -866,7 +866,7 @@ static int storvsc_channel_init(struct hv_device > *device, bool is_fc) > * We will however populate all the slots to evenly distribute > * the load. > */ > - stor_device->stor_chns = kzalloc(sizeof(void *) * > num_possible_cpus(), > + stor_device->stor_chns = kcalloc(num_possible_cpus(), sizeof(void > *), > GFP_KERNEL); > if (stor_device->stor_chns == NULL) > return -ENOMEM; > -- > 2.12.0