Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753716AbdDMX64 (ORCPT ); Thu, 13 Apr 2017 19:58:56 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:59773 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752635AbdDMX6z (ORCPT ); Thu, 13 Apr 2017 19:58:55 -0400 Date: Fri, 14 Apr 2017 08:58:50 +0900 From: Simon Horman To: Alexandre Belloni Cc: Javier Martinez Canillas , Mark Rutland , devicetree@vger.kernel.org, Wolfram Sang , Russell King , linux-kernel@vger.kernel.org, Rob Herring , Geert Uytterhoeven , Peter Rosin , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 05/22] ARM: dts: at91: Add generic compatible string for I2C EEPROM Message-ID: <20170413235850.GA6944@verge.net.au> References: <20170413182839.25381-1-javier@osg.samsung.com> <20170413182839.25381-6-javier@osg.samsung.com> <869a0f44-6c97-2109-776b-6da9b86c732a@axentia.se> <20170413212059.unh2mfo2w4oc4t33@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170413212059.unh2mfo2w4oc4t33@piout.net> Organisation: Horms Solutions BV User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1172 Lines: 42 On Thu, Apr 13, 2017 at 11:20:59PM +0200, Alexandre Belloni wrote: > On 13/04/2017 at 18:09:56 -0300, Javier Martinez Canillas wrote: > > Hello Peter, > > > > On 04/13/2017 05:43 PM, Peter Rosin wrote: > > > On 2017-04-13 20:28, Javier Martinez Canillas wrote: > > > > [snip] > > > > >> > > >> eeprom@50 { > > >> - compatible = "nxp,24c02"; > > >> + compatible = "nxp,24c02","atmel,24c02"; > > >> reg = <0x50>; > > >> pagesize = <16>; > > >> }; > > >> > > > > > > Sure, in principle. But not having a space after the commas is a real OCD > > > trigger for me. My spine is rotating... :-) > > > > > > > Right, Geert already pointed out. It's something I missed in my sed script > > so I got it wrong in all the DTS :( > > > > I'll fix my script and send a v2. > > > > That would be v3, right? ;) > > > > Anyway, with those whitespace fixes (and without them too, but please): > > > Acked-by: Peter Rosin > > > > > > > Thanks for the review! > > > > I'd like to be copied on the first patches to ensure they are applied > before applying that one. (Also, it is probably too late for 4.12 anyway > because we are past rc6). Ditto