Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261932AbTFBFx0 (ORCPT ); Mon, 2 Jun 2003 01:53:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261936AbTFBFx0 (ORCPT ); Mon, 2 Jun 2003 01:53:26 -0400 Received: from holomorphy.com ([66.224.33.161]:45724 "EHLO holomorphy") by vger.kernel.org with ESMTP id S261928AbTFBFxX (ORCPT ); Mon, 2 Jun 2003 01:53:23 -0400 Date: Sun, 1 Jun 2003 23:05:46 -0700 From: William Lee Irwin III To: "Adam J. Richter" Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: 2.5.70-bk[56] breaks disk partitioning with multiple IDE disks Message-ID: <20030602060546.GM8978@holomorphy.com> Mail-Followup-To: William Lee Irwin III , "Adam J. Richter" , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org References: <200306020045.h520j9v15291@freya.yggdrasil.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200306020045.h520j9v15291@freya.yggdrasil.com> Organization: The Domain of Holomorphy User-Agent: Mutt/1.5.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 768 Lines: 22 On Sun, Jun 01, 2003 at 05:45:09PM -0700, Adam J. Richter wrote: > @@ -1436,6 +1437,9 @@ > spin_unlock(&drivers_lock); > if(idedefault_driver.attach(drive) != 0) > panic("ide: default attach failed"); > + spin_lock(&drives_lock); > + list_add_tail(&drive->list, &ata_unused); > + spin_unlock(&drives_lock); > return 1; > } This looks dubious; check idedefault_driver.attach(). It was just put on another list. I don't know what you're trying to do but list_move_tail() would at least not be as oopsable. -- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/