Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753270AbdDNDri (ORCPT ); Thu, 13 Apr 2017 23:47:38 -0400 Received: from mail.kernel.org ([198.145.29.136]:33890 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751544AbdDNDrc (ORCPT ); Thu, 13 Apr 2017 23:47:32 -0400 Date: Fri, 14 Apr 2017 11:47:00 +0800 From: Shawn Guo To: Andrey Smirnov Cc: yurovsky@gmail.com, Sascha Hauer , Fabio Estevam , Rob Herring , Mark Rutland , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 6/8] ARM: dts: imx7d-sdb: Add GPIO expander node Message-ID: <20170414034659.GH14915@dragon> References: <20170413133242.5068-1-andrew.smirnov@gmail.com> <20170413133242.5068-7-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170413133242.5068-7-andrew.smirnov@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2135 Lines: 79 On Thu, Apr 13, 2017 at 06:32:40AM -0700, Andrey Smirnov wrote: > Add node for U38, a 74LV595PW serial-in shift register that acts as a > GPIO expander on the board. > > Cc: yurovsky@gmail.com > Cc: Sascha Hauer > Cc: Fabio Estevam > Cc: Rob Herring > Cc: Mark Rutland > Cc: Russell King > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Andrey Smirnov > --- > arch/arm/boot/dts/imx7d-sdb.dts | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts > index 5be01a1..e0ff276 100644 > --- a/arch/arm/boot/dts/imx7d-sdb.dts > +++ b/arch/arm/boot/dts/imx7d-sdb.dts > @@ -52,6 +52,30 @@ > reg = <0x80000000 0x80000000>; > }; > > + spi4 { > + compatible = "spi-gpio"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_spi1>; > + status = "okay"; The 'status' is not needed in this case. > + gpio-sck = <&gpio1 13 0>; > + gpio-mosi = <&gpio1 9 0>; > + cs-gpios = <&gpio1 12 0>; > + num-chipselects = <1>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + gpio_spi: gpio_spi@0 { gpio-expander might be a better node name? > + compatible = "fairchild,74hc595"; > + gpio-controller; > + #gpio-cells = <2>; > + reg = <0>; > + registers-number = <1>; > + /* Enable PERI_3V3, SENSOR_RST_B and HDMI_RST*/ > + registers-default = /bits/ 8 <0x74>; I do not see this property is documented or supported by kernel. > + spi-max-frequency = <100000>; > + }; > + }; > + > regulators { > compatible = "simple-bus"; > #address-cells = <1>; > @@ -642,5 +666,13 @@ > fsl,pins = < > MX7D_PAD_LPSR_GPIO1_IO01__PWM1_OUT 0x110b0 > >; > + > + pinctrl_spi1: spi1grp { > + fsl,pins = < > + MX7D_PAD_GPIO1_IO09__GPIO1_IO9 0x59 > + MX7D_PAD_GPIO1_IO12__GPIO1_IO12 0x59 > + MX7D_PAD_GPIO1_IO13__GPIO1_IO13 0x59 > + >; > + }; > }; > }; > -- > 2.9.3 >