Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751787AbdDNHde (ORCPT ); Fri, 14 Apr 2017 03:33:34 -0400 Received: from mail-ua0-f173.google.com ([209.85.217.173]:36204 "EHLO mail-ua0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751371AbdDNHdb (ORCPT ); Fri, 14 Apr 2017 03:33:31 -0400 MIME-Version: 1.0 In-Reply-To: <20170413234923.GA38321@dtor-ws> References: <20170413234923.GA38321@dtor-ws> From: Christian Gmeiner Date: Fri, 14 Apr 2017 09:33:09 +0200 Message-ID: Subject: Re: [PATCH] Input: ar1021 - do not force raising edge IRQ trigger To: Dmitry Torokhov Cc: linux-input , Martin Kepplinger , Guenter Roeck , Wolfram Sang , Jean Delvare , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 591 Lines: 16 2017-04-14 1:49 GMT+02:00 Dmitry Torokhov : > We should not be forcing edge triggered interrupt, but rather let platform > decide the kind of trigger it needs to use. Also, the driver is not quite > safe with regard to edge-triggered interrupts as it does not try to kick > the controller after requesting/enabling IRQ. > > Signed-off-by: Dmitry Torokhov Reviewed-By: Christian Gmeiner greets -- Christian Gmeiner, MSc https://www.youtube.com/user/AloryOFFICIAL https://soundcloud.com/christian-gmeiner