Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752512AbdDNHxv (ORCPT ); Fri, 14 Apr 2017 03:53:51 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:32990 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751235AbdDNHxt (ORCPT ); Fri, 14 Apr 2017 03:53:49 -0400 Date: Fri, 14 Apr 2017 09:53:43 +0200 From: Richard Cochran To: Rafal Ozieblo Cc: David Miller , nicolas.ferre@atmel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, harinikatakamlinux@gmail.com, harini.katakam@xilinx.com, Andrei.Pistirica@microchip.com Subject: Re: [PATCH 4/4] net: macb: Add macb_ptp to compilation chain Message-ID: <20170414075343.GB1660@localhost.localdomain> References: <1492090439-11793-1-git-send-email-rafalo@cadence.com> <1492090798-16253-1-git-send-email-rafalo@cadence.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1492090798-16253-1-git-send-email-rafalo@cadence.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 373 Lines: 12 On Thu, Apr 13, 2017 at 02:39:58PM +0100, Rafal Ozieblo wrote: > Add macb_ptp.c to Makefile. > In case that macb is compiled as a module, it has been renamed to > cadence-macb.ko to avoid naming confusion in Makefile. Renaming modules will break user's modpobe scripts. Why not keep macb.ko as the build product and rename macb.c to macb_main.c instead? Thanks, Richard