Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752737AbdDNLkA (ORCPT ); Fri, 14 Apr 2017 07:40:00 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:28965 "EHLO epoutp01.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752574AbdDNLj5 (ORCPT ); Fri, 14 Apr 2017 07:39:57 -0400 X-AuditID: b6c32a2c-f79be6d0000051f7-60-58f0b50ac48d From: Bartlomiej Zolnierkiewicz To: Aaro Koskinen Cc: Tomi Valkeinen , Lars-Peter Clausen , linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fbdev: omapfb: delete check_required_callbacks() Date: Fri, 14 Apr 2017 13:39:50 +0200 Message-id: <3527837.jmLdPIAKUs@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170407190407.30265-1-aaro.koskinen@iki.fi> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnleLIzCtJLcpLzFFi42LZdlhTU5dr64cIg8sbjCzWvHCwWDJ5PqvF ib4PrBaXd81hs5i9pJ/FYv38W2wObB6Hvy5k8Vjy5hCrx/Eb25k8Pm+SC2CJ4rJJSc3JLEst 0rdL4MpYe/UeU8F5loqf1xqZGxifM3cxcnJICJhIXNzwmxXCFpO4cG89G4gtJLCUUeLXjYwu Ri4gu51JYu7ptywwDW29n9ghEssZJT7O/MwE0fGVUWLyoWAQm03ASmJi+ypGEFtEQEPi1b5+ VpAGZoHVjBI/ntwEWycs4Crx+c5ksGYWAVWJU2tOsIPYvAKaEr1fn4I1iwp4SWzZ1w5Wwwk0 9PmUZmaIGkGJH5PvgV3ELCAvsW//VFYIW0fi7LF1jCDLJASms0tM/n8AqIEDyJGV2HQA6mUX iR2vlzBB2MISr45vYYewpSX+Lr3FCGFPZ5TY/lsCYs5mRolVuydAFVlLHD5+EWoZn0Tv7ydM EPN5JTrahCBKPCSO9a5lgwg7Snz+ywcJrF5GiecTdzFOYJSfheSFWUhemIXkhQWMzKsYxVIL inPTU4tNCwz1ihNzi0vz0vWS83M3MYKTh5bODsZ7C7wPMQpwMCrx8G5I+BAhxJpYVlyZe4hR goNZSYS3ax1QiDclsbIqtSg/vqg0J7X4EKM0B4uSOK/GymsRQgLpiSWp2ampBalFMFkmDk6p Bkb7Be+Ym+xZPnUo2l9y81/59nHhM0eRzD1Lchb+WZa1yOz+jcdnBXPO9ovynOEK/vmuyjCw 7McNjRaNh8lHnjxTOXM+p3vR88pdmwQmt17NzPuyfuLUZ69fyyX63frXc3Bi0RSzl7EXzryf nh7mGpA/wffb+i6lrmN6Mw6I/TzhJvZhc4lND98ZJZbijERDLeai4kQA1fTlWxoDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDIsWRmVeSWpSXmKPExsVy+t9jAV2OrR8iDFY/t7FY88LBYsnk+awW J/o+sFpc3jWHzWL2kn4Wi/Xzb7E5sHkc/rqQxWPJm0OsHsdvbGfy+LxJLoAlys0mIzUxJbVI ITUvOT8lMy/dVik0xE3XQkkhLzE31VYpQtc3JEhJoSwxpxTIMzJAAw7OAe7BSvp2CW4Za6/e Yyo4z1Lx81ojcwPjc+YuRk4OCQETibbeT+wQtpjEhXvr2boYuTiEBJYySsx8+YkRwvnKKPGk vRmsg03ASmJi+ypGEFtEQEPi1b5+VpAiZoHVjBJT26+ygSSEBVwlPt+ZzARiswioSpxacwJs Ba+ApkTv16dgzaICXhJb9rWD1XACDX0+BWQByLZ+Rone3ulQDYISPybfYwGxmQXkJfbtn8oK YWtJrN95nGkCo8AsJGWzkJTNQlK2gJF5FaNEakFyQXFSeq5RXmq5XnFibnFpXrpecn7uJkZw TD2T3sF4eJf7IUYBDkYlHt6I2vcRQqyJZcWVuYcYJTiYlUR4u9Z9iBDiTUmsrEotyo8vKs1J LT7EaAr04URmKdHkfGC855XEG5qYm5gbG1iYW1qaGCmJ8zbOfhYuJJCeWJKanZpakFoE08fE wSnVwOjyas+rkkmOyfOCWJhb004lr7zDFTZ1XqbVjEuSklM+t661qHGW5FFZ6L9fJ3NBp/id 9FPN/n8CXu5S0Qlc9unyv9erTBj1OS2+nOB2PfSyMGG6u+anJ7UHcjuWLDVfrKA+NbxYNG2j 2wn2BbELTs2vuJL0ZhPTghBRqRlyXXVpttrPM7c9D1FiKc5INNRiLipOBABRBmOgvwIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170414113953epcas5p399b08cac103abc5802d2fa177a9d4d74 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-CMS-RootMailID: 20170407191340epcas4p11d5a19fff9d86cae47195552421a3ae0 X-RootMTR: 20170407191340epcas4p11d5a19fff9d86cae47195552421a3ae0 References: <20170407190407.30265-1-aaro.koskinen@iki.fi> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 572 Lines: 19 Hi, On Friday, April 07, 2017 10:04:07 PM Aaro Koskinen wrote: > Commit 561eb9d09a93 ("fbdev: omap/lcd: Make callbacks optional") made > panel callbacks optional but forgot to update check_required_callbacks(). > As a result many (all?) OMAP systems using omapfb will crash at boot. > Fix by deleting the whole function. > > Fixes: 561eb9d09a93 ("fbdev: omap/lcd: Make callbacks optional") > Signed-off-by: Aaro Koskinen Patch queued for 4.11, thanks! Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics