Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752192AbdDNMcj (ORCPT ); Fri, 14 Apr 2017 08:32:39 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34676 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751521AbdDNMch (ORCPT ); Fri, 14 Apr 2017 08:32:37 -0400 Date: Fri, 14 Apr 2017 14:32:26 +0200 From: Greg KH To: Vincent Legoll Cc: arve@android.com, riandrews@android.com, devel@driverdev.osuosl.org, Linux Kernel ML Subject: Re: [PATCH] Make ANDROID a menuconfig to ease disabling it all Message-ID: <20170414123226.GB17217@kroah.com> References: <20170414090421.4281-1-vincent.legoll@gmail.com> <20170414092705.GA1944@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.1 (2017-04-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 999 Lines: 25 On Fri, Apr 14, 2017 at 11:46:07AM +0200, Vincent Legoll wrote: > Hello, > > >> No need to get into the submenu to disable all ANDROID-related config entries > > > > I don't understand this, what exactly do you mean? > > This is intended for people using make menuconfig to tailor > their kernel config to their need by disabling all options they > don't need. In order to have a smaller kernel, for example, > but also to get smaller build times. That's fine, but you aren't actually changing the functionality of any of the build options here. You are just adding a 'menu' and showing things a bit differently. You aren't changing any dependancies (which is what dictates what is and is not built), which does not make it easier, or harder, to disable/enable anything here. I'm not against this, but you need to explain it a lot better as to what you are doing and why. The "why" isn't covered by the "this will make the kernel build smaller", as that's just not true :) thanks, greg k-h